Upgrade the codebase to use paf-le-chien instead of CoHTTP#3
Open
dinosaure wants to merge 4 commits into
Open
Conversation
Author
|
This PR needs yomimono/chamelon#5 to works. |
Author
|
Currently, this version is running here: https://url.osau.re/ (the certificate is a fake one - I got some trouble with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wants to upgrade your unikernel with
paf-le-chienwhich integrates stuffs required for Let's encrypt challenges. We already did some benchmarks withunipiand it seems thatpafis better about performances. I took the opportunity to upgrade the POST request to send amultipart/formrequest instead of an URL-encoded request - you can checkmultipart_formfor that.Of course, the code use
http/afand I added a new argument to be able to launch a simple HTTP server (without certificates). It's a draft and this PR will be improve after the integration of mirage/mirage#1300 and some tests on my side.