fix: repair invalid GitHub Issue Form YAML templates - #267
Merged
Merged
Conversation
Flow-style attributes mappings across all five Issue Form templates held unquoted comma-separated description text, which YAML parsed as extra sibling properties instead of a single description string. This broke gh-inari schema compilation with ISSUE_FORM_UNKNOWN_PROPERTY for every template (architecture, bug, feature, maintenance, research). Quote each affected description value so the full sentence parses as one string, preserving the original field labels and semantics. Also commit .mcp.json (MCP server config for local Mottainai tooling). Closes #229 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe pull request reformats five GitHub issue templates and adds an ChangesIssue Template YAML Formatting
MCP Configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
This was referenced Aug 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair all five repository Issue Form templates so they compile through gh-inari and render as valid GitHub Issue Forms.
Linked issue
#229
Scope
All
.github/ISSUE_TEMPLATE/*.ymlfiles (architecture, bug, feature, maintenance, research).Included
Quoted every flow-style
descriptionvalue that contained unquoted commas or semicolons, so YAML parses it as a single string instead of splitting it into extra sibling properties on theattributesmapping. Field labels, ids, and semantics are unchanged. Also committed.mcp.json(local Mottainai MCP server config).Excluded
No change to gh-inari's parser or to the GitHub-native Issue Form schema itself; the templates now conform to the existing schema rather than requiring the schema to be loosened.
Implementation
Each broken block was a flow-style YAML mapping (
{ label: ..., description: ... }) where the description text itself contained commas (e.g. "Boundary, invariant, and observable contract..."). Because flow mappings treat unquoted commas as key/value separators, YAML parsed the trailing comma-separated fragments as additional top-level keys underattributes(e.g.invariant: null,and observable contract...: null), which gh-inari's Issue Form schema compiler rejects withISSUE_FORM_UNKNOWN_PROPERTY. Wrapping each affected description in double quotes restores it to a single scalar value.Behavioral changes
None to application behavior. Issue creation via
gh inari issue createandgh inari issue schema/validatenow succeeds for all five templates instead of failing before this fix.Validation
Test layers:
pnpm testpnpm run test:integrationpnpm run test:e2e,pnpm run test:packagepnpm run verify:standardspnpm run test:coveragepnpm run test:effectivenesspnpm run verifyTest contract
gh inari issue schema <template>must returnok(or a valid contract) for architecture, bug, feature, maintenance, and research with no ISSUE_FORM_UNKNOWN_PROPERTY violations.Regression proof
Before: all five templates failed
gh inari issue schema <template>with ISSUE_FORM_UNKNOWN_PROPERTY listing the leaked comma fragments as unsupported properties. After: all five return a clean 14-field contract with the original field ids intact (verified viagh inari issue schemaand by parsing each YAML file with PyYAML to confirm everyattributesmapping now contains onlylabel/description/value).Validation evidence
Ran
gh inari issue schema <template>for architecture, bug, feature, maintenance, and research after the fix — all five returnedokcontracts with the expected 14 fields each. Cross-checked with a PyYAML parse of each file confirming no stray keys remain under anyattributesblock.Release impact
None. Documentation/governance-only change to Issue Form templates; no package or runtime artifact affected.
Risks
Low. Text-only quoting fix; no field ids, labels, or required-ness changed.
Breaking changes
None.
Migration / compatibility
N/A — no schema version or contract shape changes beyond fixing the malformed YAML.
Security impact
None. No security boundary touched.
Review focus
Confirm each quoted description preserves the original intended wording and that no field was accidentally dropped or renamed.