-
-
Notifications
You must be signed in to change notification settings - Fork 12
[Feature] Transfer Link between multiple device #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Feature] Transfer Link between multiple device #234
Conversation
…feature/transfer-links
…feature/transfer-links # Conflicts: # app/src/main/java/com/yogeshpaliyal/deepr/ui/screens/LocalNetworkServer.kt
|
@yogeshpaliyal Please review this PR |
|
@Mutant-Slayer A different screen for transfer links would be more user friendly instead of using inside Local Network Server |
|
@yogeshpaliyal thats a different screen, its just that the UI is almost same. If you have any recommendation i can tweak the Ui as per that. |
|
Change Menu Item text to transfer Links to another device, and add it to CSV Management section, and you can rename that to Import/Export |
|
@yogeshpaliyal changes done |
| import kotlinx.coroutines.launch | ||
| import org.koin.android.ext.android.inject | ||
|
|
||
| class TransferLinkLocalServerService : Service() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead you can reuse the same service LocalServerService
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yogeshpaliyal how will i separate the port , both the server will be considered running at same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can pass port as paramter of method
| import java.net.NetworkInterface | ||
| import java.util.Locale | ||
|
|
||
| class TransferLinkLocalServerRepositoryImpl( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use existing repository, just add a new API or use existing API's
…feature/transfer-links # Conflicts: # app/src/main/java/com/yogeshpaliyal/deepr/DeeprApplication.kt # app/src/main/java/com/yogeshpaliyal/deepr/ui/screens/Settings.kt
Changes
Recording
Note: In video one can also check it does not import duplicated data
Screen_recording_20251025_113717.mp4