Adding timeouts to all remote requests #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I faced problem, when thread became unaccessible because of long answer from Docker Hub registry. I think, all requests to remote APIs should have reasonable timeouts. For me - it's about 10 seconds. If API is not responding - I prefer to get exception and not wait for a lifetime. But Python Requests library has no timeout by default.
So I've added optional parameter, which can be used like:
where
api_timeout
could be float or tuple according to requests docs.