Skip to content

Support puma 6 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2022
Merged

Support puma 6 #46

merged 2 commits into from
Dec 11, 2022

Conversation

tricknotes
Copy link
Contributor

This PR supports Puma 5 and 6.

Close #43

@tricknotes
Copy link
Contributor Author

My application works fine on Puma 5 and 6 with this change.

@tricknotes tricknotes mentioned this pull request Nov 26, 2022
Closed
yob
yob approved these changes Dec 11, 2022
View reviewed changes
Copy link
Owner

@yob yob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've tested this on puma 5 and 6, and it all works as expected ✨

I'd like to release this as 2.4.0 in a week or two - is anyone keen to load main via git and dogfood the pre-released version on prod for me?

@yob yob merged commit b0b4fdf into yob:main Dec 11, 2022
@tricknotes tricknotes deleted the support-puma-6 branch December 11, 2022 06:51
@epintos
Copy link

epintos commented Dec 14, 2022

@yob @tricknotes thanks for this! When are you planning to release 2.4.0?

@yob
Copy link
Owner

yob commented Dec 27, 2022

I've just released 2.4.0 with this PR - please let me know how it goes with both puma 5 and 6 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yob yob yob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Puma 6.0.0
4 participants
@tricknotes @epintos @yob @danarnold