Add content length #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XMLHttpRequet supports BufferSource as a send parameter, and this is used to transmit binary to the server as part of the POST method. Node also supports transmitting binary in its HttpClient, which is the underlying implementation in w3c-xmlhttprequest. To utilise this you pass a Buffer into the client.write() method, but w3c-xmlhttprequest only writes String or FormData. The first patch modifies the check to support Buffer as a body. The second path detect ArrayBuffer or Uint8Array as a body, and then converts to Buffer using Buffer.from(). This means that you can now use the XHR in-place of XMLHttpRequests which pass ArrayBuffer or Uint8Array. Being able to use Buffer as well in Node is a pleasant side-effect. Improvements: Buffer.from() actually supports many more types, which could be used. Also, it is possible to convert typed-arrays to Buffer directly.
Adds support for ArrayBuffer, Uint8Array and Buffer to send(body)
Some servers do not accept unbounded requests. Add the Content-Length header to rectify
``` /Users/stux/git/node-xmlhttprequest/lib/xmlhttprequest.js 342:7 error Keyword "if" must be followed by whitespace space-after-keywords ✖ 1 problem (1 error, 0 warnings) ``` Fixed.
Fix lint error
ykzts
added a commit
that referenced
this pull request
Jul 22, 2020
* Adds support for ArrayBuffer, Uint8Array and Buffer to send(body) XMLHttpRequet supports BufferSource as a send parameter, and this is used to transmit binary to the server as part of the POST method. Node also supports transmitting binary in its HttpClient, which is the underlying implementation in w3c-xmlhttprequest. To utilise this you pass a Buffer into the client.write() method, but w3c-xmlhttprequest only writes String or FormData. The first patch modifies the check to support Buffer as a body. The second path detect ArrayBuffer or Uint8Array as a body, and then converts to Buffer using Buffer.from(). This means that you can now use the XHR in-place of XMLHttpRequests which pass ArrayBuffer or Uint8Array. Being able to use Buffer as well in Node is a pleasant side-effect. Improvements: Buffer.from() actually supports many more types, which could be used. Also, it is possible to convert typed-arrays to Buffer directly. * add Content-Length to requests with a body Some servers do not accept unbounded requests. Add the Content-Length header to rectify * Fix lint error ``` /Users/stux/git/node-xmlhttprequest/lib/xmlhttprequest.js 342:7 error Keyword "if" must be followed by whitespace space-after-keywords ✖ 1 problem (1 error, 0 warnings) ``` Fixed. Co-authored-by: Stuart Espey <[email protected]> Co-authored-by: Yamagishi Kazutoshi <[email protected]>
ykzts
added a commit
that referenced
this pull request
Jul 22, 2020
* Adds support for ArrayBuffer, Uint8Array and Buffer to send(body) (#45) * Adds support for ArrayBuffer, Uint8Array and Buffer to send(body) XMLHttpRequet supports BufferSource as a send parameter, and this is used to transmit binary to the server as part of the POST method. Node also supports transmitting binary in its HttpClient, which is the underlying implementation in w3c-xmlhttprequest. To utilise this you pass a Buffer into the client.write() method, but w3c-xmlhttprequest only writes String or FormData. The first patch modifies the check to support Buffer as a body. The second path detect ArrayBuffer or Uint8Array as a body, and then converts to Buffer using Buffer.from(). This means that you can now use the XHR in-place of XMLHttpRequests which pass ArrayBuffer or Uint8Array. Being able to use Buffer as well in Node is a pleasant side-effect. Improvements: Buffer.from() actually supports many more types, which could be used. Also, it is possible to convert typed-arrays to Buffer directly. * delint * Fix syntax Co-authored-by: Stuart Espey <[email protected]> Co-authored-by: Yamagishi Kazutoshi <[email protected]> * Add content length (#46) * Adds support for ArrayBuffer, Uint8Array and Buffer to send(body) XMLHttpRequet supports BufferSource as a send parameter, and this is used to transmit binary to the server as part of the POST method. Node also supports transmitting binary in its HttpClient, which is the underlying implementation in w3c-xmlhttprequest. To utilise this you pass a Buffer into the client.write() method, but w3c-xmlhttprequest only writes String or FormData. The first patch modifies the check to support Buffer as a body. The second path detect ArrayBuffer or Uint8Array as a body, and then converts to Buffer using Buffer.from(). This means that you can now use the XHR in-place of XMLHttpRequests which pass ArrayBuffer or Uint8Array. Being able to use Buffer as well in Node is a pleasant side-effect. Improvements: Buffer.from() actually supports many more types, which could be used. Also, it is possible to convert typed-arrays to Buffer directly. * add Content-Length to requests with a body Some servers do not accept unbounded requests. Add the Content-Length header to rectify * Fix lint error ``` /Users/stux/git/node-xmlhttprequest/lib/xmlhttprequest.js 342:7 error Keyword "if" must be followed by whitespace space-after-keywords ✖ 1 problem (1 error, 0 warnings) ``` Fixed. Co-authored-by: Stuart Espey <[email protected]> Co-authored-by: Yamagishi Kazutoshi <[email protected]> Co-authored-by: Stuart Espey <[email protected]> Co-authored-by: Stuart Espey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers do not accept unbounded POST requests. Add the Content-Length header to rectify