POST results in "TypeError: Cannot read property 'lengthComputable' of undefined"

[taku0]

Summary

POST with body results in "TypeError: Cannot read property 'lengthComputable' of undefined" because XMLHttpRequestUpload doesn't have _properties.

Sample Code

const http = require('http');
const XMLHttpRequest = require('w3c-xmlhttprequest').XMLHttpRequest;

const server = http.createServer((req, res) => {
  res.end();
});
server.on('clientError', (err, socket) => {
  socket.end('HTTP/1.1 400 Bad Request\r\n\r\n');
});
server.listen(8000);

const client = new XMLHttpRequest();

client.open("POST", "http://localhost:8000");
client.send("abcdefg");

Result

~/src/node-xmlhttprequest/lib/xmlhttprequest.js:129
      lengthComputable: _properties.lengthComputable,
                                   ^

TypeError: Cannot read property 'lengthComputable' of undefined
    at Socket.<anonymous> (/home/takuo/src/node-xmlhttprequest/lib/xmlhttprequest.js:129:36)
    at emitOne (events.js:82:20)
    at Socket.emit (events.js:169:7)
    at readableAddChunk (_stream_readable.js:146:16)
    at Socket.Readable.push (_stream_readable.js:110:10)
    at TCP.onread (net.js:523:20)

Version

2.1.0 and master (383319c)

Cause

_setDispatchProgressEvents read this._properties while this is bound to XMLHttpRequest#upload which doesn't have _properties.

function _setDispatchProgressEvents(stream) {
  const _properties = this._properties;

      client.on('socket', _setDispatchProgressEvents.bind(this.upload));

Possible Fix

Defining _properties on XMLHttpRequestUpload.

[sibelius]

@ykzts @taku0 I can confirm this

any progress on this?

[ykzts]

@taku0 @sibelius

I think that it might have been fixed.

v2.1.2 released.