[Privacy Manifest] Adjust resource layout for SPM and CocoaPods

[ncooke3]

The path we provide here is relative to the sources within the target. This would be ./Sources/FBLPromises/. So we need to jump one directory back and into Resources. Otherwise, there will be a warning that the resource is specified but not found.

warning: 'promises': Invalid Resource 'Sources/Resources/PrivacyInfo.xcprivacy': File not found.

-        .process("Sources/Resources/PrivacyInfo.xcprivacy")
+        .process("../Resources/PrivacyInfo.xcprivacy")

But, although the above resolves, SPM doesn't actually bundle the resource in the target's build directory when the resource paths are relative like this 😖 .

What does work is copying the Resources directory into both the FBLPromises and Promises. I tried symlinking Sources/FBLPromises/Resources and Sources/Promises/Resources to Sources/Resources so we could avoid duplicating the manifest contents since the contents is the same for both modules. Unfortunately, SPM won't pick up the symlink even though readlink output looks right.

So, the only path that leads to a working outcome is to remove the Sources/Resources/ and add a Resources/ to both Sources/Promises/ and Sources/FBLPromises/. This is a good learning for cases where targets share the same manifest contents–– it appears that they cannot point to a shared location.

cc: @thomasvl

I updated the podspec to reflect these changes.

---

Verification

All of the below cases generate an empty Privacy Report which is expected. The important part was making sure the xcprivacy file ends up in a name spaced part of the app bundle.

• App depending via SPM

PrivacyApp.app
├── Info.plist
├── PkgInfo
├── PrivacyApp
├── Promises_FBLPromises.bundle
│   ├── Info.plist
│   └── PrivacyInfo.xcprivacy  ← ✅
├── Promises_Promises.bundle
│   ├── Info.plist
│   └── PrivacyInfo.xcprivacy  ← ✅
├── _CodeSignature
│   └── CodeResources
└── embedded.mobileprovision

• App depending on Promises via CocoaPods (dynamically linked)

/PrivacyAppCocoaPods.app
├── Frameworks
│   ├── FBLPromises.framework
│   │   ├── FBLPromises
│   │   ├── FBLPromises_Privacy.bundle
│   │   │   ├── Info.plist
│   │   │   └── PrivacyInfo.xcprivacy  ← ✅
│   │   ├── Info.plist
│   │   └── _CodeSignature
│   │       └── CodeResources
│   └── Promises.framework
│       ├── Info.plist
│       ├── Promises
│       ├── Promises_Privacy.bundle
│       │   ├── Info.plist
│       │   └── PrivacyInfo.xcprivacy  ← ✅
│       └── _CodeSignature
│           └── CodeResources
├── Info.plist
├── PkgInfo
├── PrivacyAppCocoaPods
├── _CodeSignature
│   └── CodeResources
└── embedded.mobileprovision

• App depending on Promises via CocoaPods (statically linked)

PrivacyAppCocoaPods.app
├── FBLPromises_Privacy.bundle
│   ├── Info.plist
│   └── PrivacyInfo.xcprivacy  ← ✅
├── Info.plist
├── PkgInfo
├── PrivacyAppCocoaPods
├── Promises_Privacy.bundle
│   ├── Info.plist
│   └── PrivacyInfo.xcprivacy  ← ✅
├── _CodeSignature
│   └── CodeResources
└── embedded.mobileprovision

[ykjchen]

Thank you for your help in getting this right, and the detailed explanation!