Skip to content

Commit

Permalink
refactor: dashboard with new manifests structure (opendatahub-io#1065)
Browse files Browse the repository at this point in the history
Partial application of already applied:

commit 438f4c2
Author: Wen Zhou <[email protected]>
Date:   Tue Jul 2 16:56:25 2024 +0200

    refactor: dashboard with new manifests structure (opendatahub-io#1065)

    * refactor: dashboard with new manifests structure

    - change type of platform, skip convert to string
    - add more support for ApplyParam() to
      not only take ENV but also anything from ExtraParamMaps
    * update: simplify override function
    * update: add value for Unknown platform
    ---------

    Signed-off-by: Wen Zhou <[email protected]>

Signed-off-by: Yauheni Kaliuta <[email protected]>
  • Loading branch information
ykaliuta committed Aug 27, 2024
1 parent 6d0e52d commit ef13428
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/modelregistry/modelregistry.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ type ModelRegistry struct {
components.Component `json:""`
}

func (m *ModelRegistry) OverrideManifests(ctx context.Context, _ string) error {
func (m *ModelRegistry) OverrideManifests(ctx context.Context, _ cluster.Platform) error {
// If devflags are set, update default manifests path
if len(m.DevFlags.Manifests) != 0 {
manifestConfig := m.DevFlags.Manifests[0]
Expand Down Expand Up @@ -71,7 +71,7 @@ func (m *ModelRegistry) ReconcileComponent(ctx context.Context, cli client.Clien
if enabled {
if m.DevFlags != nil {
// Download manifests and update paths
if err := m.OverrideManifests(ctx, string(platform)); err != nil {
if err := m.OverrideManifests(ctx, platform); err != nil {
return err
}
}
Expand Down

0 comments on commit ef13428

Please sign in to comment.