Refactor microsoft#7559 into "Select Matches" icon #1
+1,329,639
−640,086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Localize ipynb extension commands * More updates
save IW before shutdown to discard working copy backup
Do not block if unable to verify extension signature
* fix microsoft#172617 * fix tests
…om playing sounds.
When testing a new feature to disable debug treatment of the status bar, I found that debugging felt _much_ more snappy when there wasn't a big slow color fade on the status bar. Rob agreed it was a bit "dramatic." A 150ms fade instead of a 350ms fade feels much nicer, I think we should try this out for next month's Insiders.
Fixes microsoft#167741 This eschews the offical Windows service system in favor of registering into `HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run`. Unlike services, this can be done without administrative permissions, does not require the current username/password, and is not blocked by miscellaneous and mysterious system policies. Since the process is basically unmanaged by the OS, this requires a little legwork to start and stop the process when registering and unregistering.
Februrary input
Fixes observable bug
…moset Fixes microsoft#166074. When play fails, the sound must be removed from playing sounds.
…dows Fixes compilation in windows
joh/witty cuckoo
…_yarn/http-cache-semantics-4.1.1 Bump http-cache-semantics from 4.1.0 to 4.1.1
Fix race when registering extension quick fix providers
Tweak clear command history command name
This allows extensions to register content to go right after this button by also specifying order 1. 1 was chosen because we want this to be the first piece of content in the debug view.
* Consolidate menu entries * Use online services name
fix editor ID for IW editor input
We use `expand-all` for the "select matches" icon. We also rename from "find all" to "select all" for microsoft#128915. Refs: ec02bcd & microsoft#14836
…indwidget-select-matches-icon
zm-cttae
changed the title
|
@yisibl are you still interested in microsoft#7559? |
zm-cttae
changed the title
|
I'm interested, but the problem is that vscode has been slow to come up with a clear official stance. |
|
(looped in core UI/UX) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft#7559
Use ThemeIcon for "select matches" in find widget
For the "select matches" icon we use
expand-all.We also rename from "find all" to "select all" for microsoft#128915.
Refs: ec02bcd & microsoft#14836