Add AccountPermission

yinyiqian1 · Nov 4, 2024 · dff8719 · dff8719
1 parent 50dbe3d
commit dff8719
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/include/xrpl/protocol/detail/sfields.macro b/include/xrpl/protocol/detail/sfields.macro
@@ -263,6 +263,7 @@ TYPED_SFIELD(sfUnauthorize,              ACCOUNT,    6)
 TYPED_SFIELD(sfRegularKey,               ACCOUNT,    8)
 TYPED_SFIELD(sfNFTokenMinter,            ACCOUNT,    9)
 TYPED_SFIELD(sfEmitCallback,             ACCOUNT,   10)
+TYPED_SFIELD(sfOnBehalfOf,               ACCOUNT,   11)
 
 // account (uncommon)
 TYPED_SFIELD(sfHookAccount,              ACCOUNT,   16)

diff --git a/src/libxrpl/protocol/TxFormats.cpp b/src/libxrpl/protocol/TxFormats.cpp
@@ -45,6 +45,7 @@ TxFormats::TxFormats()
         {sfTxnSignature, soeOPTIONAL},
         {sfSigners, soeOPTIONAL},  // submit_multisigned
         {sfNetworkID, soeOPTIONAL},
+        {sfOnBehalfOf, soeOPTIONAL},
     };
 
 #pragma push_macro("UNWRAP")

diff --git a/src/xrpld/app/tx/detail/AMMCreate.cpp b/src/xrpld/app/tx/detail/AMMCreate.cpp
@@ -88,6 +88,26 @@ AMMCreate::calculateBaseFee(ReadView const& view, STTx const& tx)
 TER
 AMMCreate::preclaim(PreclaimContext const& ctx)
 {
+    // if (ctx.rules.enabled(featureAccountPermission))
+    // {
+    auto const onBehalfOfAccount =
+        ctx.view.read(keylet::account(ctx.tx[sfOnBehalfOf]));
+    if (!onBehalfOfAccount)
+        return terNO_ACCOUNT;
+
+    auto const accountPermissionKey =
+        keylet::accountPermission(ctx.tx[sfAccount], ctx.tx[sfOnBehalfOf]);
+    auto const sle = ctx.view.read(accountPermissionKey);
+    if (!sle)
+        return temMALFORMED;  // todo: change error code
+
+    auto const permissions = sle->getFieldArray(sfPermissions);
+    for (auto const permission : permissions)
+    {
+    }
+
+    //}
+
     auto const accountID = ctx.tx[sfAccount];
     auto const amount = ctx.tx[sfAmount];
     auto const amount2 = ctx.tx[sfAmount2];