Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong edge highlighting in screenshots #67

Closed
un-couteau opened this issue Sep 23, 2022 · 5 comments
Closed

Strong edge highlighting in screenshots #67

un-couteau opened this issue Sep 23, 2022 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@un-couteau
Copy link

image

gnome-screenshot does this:
image

And in fact I see it this way (as in obs):
image

@yilozt
Copy link
Owner

yilozt commented Sep 27, 2022

This is the screenshot by using the builtin tools of gnome shell, I open it with eog:

图片

You can see there is an transparent area in this picture, I will try to find why this issues occurs.

图片

图片

@yilozt yilozt added help wanted Extra attention is needed bug Something isn't working labels Sep 27, 2022
@yilozt yilozt closed this as completed in d21aef7 Oct 15, 2022
@un-couteau
Copy link
Author

image
When you make a screenshot of a separate window, the bug is still there
{To get the bug, right-click on the picture and select "Open Image in New Tab"
although even so, you can see that in the corners of the selection is thinner and more prominent (which in a full-screen screenshot was not noticed)}
image
image

image
And there is no such thing with a full screen

image
{As you can see everything is perfect here}

@yilozt
Copy link
Owner

yilozt commented Oct 26, 2022

Hi @un-couteau ,I can confirm this bug, thanks to report it.

If I set the border width to a positive value, there is no strange highlighting when make screenshots to separate window.

But if I set the border width to a negative value, this bug occurs. I will try to fix it later.

@yilozt yilozt reopened this Oct 26, 2022
yilozt added a commit that referenced this issue Oct 26, 2022
if border width is a positive value (border be drawn inside of window),
we will draw rounded corners first, then mix it with border.

if border width is a negative value (border be drawn outside of window),
we will draw border color first, then mix it with rounded window.

relative to #67
@yilozt
Copy link
Owner

yilozt commented Oct 26, 2022

Should be fixed.

when set border width to positive value:

图片

when set border width to negative value:

图片

If right click on image and open it in new tab, the highlighting color should not occurs in corners of window. you can test it by download extensions pack in Github Actions if you like.

@un-couteau
Copy link
Author

Oh, man.
You're so cool.
Now it's not a shame to share screenshots
thank you for doing such a great job
it's not like kde rounded corners which is terrible
Снимок экрана от 2022-10-27 03-03-26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants