Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Migration->printException() overridable #20163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yus-ham
Copy link
Contributor

@yus-ham yus-ham commented May 17, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 13.50%. Comparing base (391997a) to head (0b6f09d).
Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
framework/db/Migration.php 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (391997a) and HEAD (0b6f09d). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (391997a) HEAD (0b6f09d)
6 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #20163      +/-   ##
============================================
- Coverage     18.65%   13.50%   -5.16%     
+ Complexity    11379    11378       -1     
============================================
  Files           430      430              
  Lines         37071    37066       -5     
============================================
- Hits           6915     5004    -1911     
- Misses        30156    32062    +1906     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley added the pr:missing usecase It is not clear what is the use case for the pull request. label May 18, 2024
@yus-ham
Copy link
Contributor Author

yus-ham commented May 25, 2024

@bizley I just want to not to print stack traces in console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:missing usecase It is not clear what is the use case for the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants