Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception messages #316

Merged
merged 18 commits into from
Dec 2, 2022
Merged

Fix exception messages #316

merged 18 commits into from
Dec 2, 2022

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Nov 9, 2022

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️
Extends #315
Depends on yiisoft/definitions#56

@xepozz xepozz requested a review from a team November 9, 2022 19:34
@xepozz xepozz added the status:code review The pull request needs review. label Nov 9, 2022
@what-the-diff
Copy link

what-the-diff bot commented Nov 9, 2022

  • Added BuildingException class.
  • Changed Container::get() method to throw a new exception if an error occurs while building the object, and not only NotFoundExceptionInterface or ContainerExceptionInterface exceptions are thrown in this case.
  • Fixed tests for cases when non-array arguments were passed into methods of objects being built by container (see testNonArrayArguments).

@samdark
Copy link
Member

samdark commented Dec 2, 2022

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1dfd6d0) compared to base (f184eb1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #316   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       152       158    +6     
===========================================
  Files             10        11    +1     
  Lines            366       377   +11     
===========================================
+ Hits             366       377   +11     
Impacted Files Coverage Δ
src/BuildingException.php 100.00% <100.00%> (ø)
src/Container.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xepozz xepozz merged commit e0b5ba8 into master Dec 2, 2022
@xepozz xepozz deleted the fix-exception-messages branch December 2, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants