Skip to content

File delete fix on high load #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2022
Merged

File delete fix on high load #50

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
adbaff9
Silent file delete if it was already deleted
Nov 7, 2022
e1c7c21
Merge remote-tracking branch 'origin/master'
Nov 7, 2022
10ff8f1
Changelog for file deletion fix
Nov 10, 2022
b59ca98
Update CHANGELOG.md
vjik Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/FileCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,17 @@ public function delete(string $key): bool
return true;
}

return @unlink($file);
$result = @unlink($file);
// Check if error was because of file was already deleted by another process on high load
if ($result === false) {
$lastError = error_get_last();
if (str_ends_with($lastError['message'] ?? '', 'No such file or directory')) {
error_clear_last();
return true;
}
}

return $result;
}

public function clear(): bool
Expand Down