[backport] feat/bench_y reuse-budget fixes onto v1.3.0rc11 (issue #13318) - #1
Closed
yifjiang wants to merge 3 commits into
Closed
[backport] feat/bench_y reuse-budget fixes onto v1.3.0rc11 (issue #13318)#1yifjiang wants to merge 3 commits into
yifjiang wants to merge 3 commits into
Conversation
…ext chunking (NVIDIA#12682) Signed-off-by: Lanyu Liao <lancelly@users.noreply.github.com> Co-authored-by: Lanyu Liao <lancelly@users.noreply.github.com>
NVIDIA#12806) Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
…VIDIA#12909) Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>
Owner
Author
|
Superseded by upstream draft PR NVIDIA#13359 — same branch, same content, opened against NVIDIA:main for CI signal and maintainer visibility. Branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR — not for upstream merge. This is a downstream-only branch on the
yifjiangfork that captures the cherry-pick state used by the dynamo-trtllm v4 production image overlay (head-health-cuda-v4-benchy-rc11). PR base isv1.3.0rc11-base(a fork-side branch pointing exactly at the upstreamv1.3.0rc11tag commit4e69c14f7), so the diff shown is exactly the three cherry-picks.Cherry-picks (in order)
c0d22ad6c(wasd9038d3b90)_estimate_post_reuse_compute()+ Python-sideremaining_budgetre-validation inprepare_resources(catches C++ scheduler over-admission before_prepare_tp_inputs). Also patchesmicroBatchScheduler.cppfor the C++ admission math; we keep the C++ change in source for fidelity but the production overlay only ships the Python parts.9faa1dd27(was01c4947990)remaining_budgetbefore first-chunk checks. Patches a bug introduced inside NVIDIA#12682's gate.e11cedca5(wasf24dcb33e1)prepare_resources) batch to_recv_disagg_gen_cache, fixingCacheReceiver::requestSyncunordered_map::atwhen a request is skipped by the budget gate. Required for our disagg deployments (Qwen3-Coder-480B).Authors preserved (Liao Lanyu, Jin Li, Lizhi Zhou). Committer rewritten to satisfy GitHub email-privacy on this fork; signed-off-by trailers from the original commits are intact.
Why this exists
Issue NVIDIA#13318 — the C++ scheduler under-counts last-chunk reuse cost, leading to
assert total_num_tokens <= self.max_num_tokenskilling the event loop. The proper upstream fix is onfeat/bench_y(16 commits ahead ofmain, 125 commits behindv1.3.0rc11). We need the fix onv1.3.0rc11now for the Qwen3-Coder-480B deployment that crashed three times on 2026-04-22. Cherry-picking the three relevant commits ontov1.3.0rc11is the cleanest available path untilfeat/bench_ylands onmainand rolls into a release wheel.Why three commits and not the whole
feat/bench_yfeat/bench_yhas 16 unique commits; the other 13 are DSA perf work, prefix-reuse refactor, and tests that are unrelated to this bug or are scoped to features we do not use. Importing them would broaden the patch surface for no reason.Cherry-pick base verification
Branch tip is "v1.3.0rc11 + the three cherry-picks, nothing else."
Cherry-pick result
All three commits applied via 3-way auto-merge with no conflicts. Files changed (vs
v1.3.0rc11):Downstream consumer
This branch is consumed by
docs/build_dynamo_trtllm_head_health_cuda_v4_benchy_rc11.mdin the claude-local-orchestrator repo. The dynamo-trtllm Docker build clones this branch, copies the three patched Python files (the C++ change is in source for fidelity but is not built into the image —has_trtllm_context: "0"), and overlays them on the installedtensorrt-llm==1.3.0rc11wheel.