Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee receiver check #83

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

xhad
Copy link
Contributor

@xhad xhad commented Apr 7, 2024

Problem

Currently the protocol FEE_RECEIVER in the deployment script is set to the deployer address, DEFAULT_SINGER.

Solution

This sets the FEE_RECEIVER properly in DeployYeildNest.s.sol and adds a check to Verify.s.sol

Copy link

remove local declartion of feeReceiver, set from global actors
@xhad xhad force-pushed the chad/sc-573/fee-receiver-check branch from 25af2b9 to 860f784 Compare April 7, 2024 02:45
Copy link
Contributor

@danoctavian danoctavian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danoctavian danoctavian merged commit 0ce1fc3 into release-candidate Apr 7, 2024
1 check passed
@xhad xhad deleted the chad/sc-573/fee-receiver-check branch April 15, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants