Fix deploy imports #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix case sensitive import
|
This pull request has been linked to Shortcut Story #573: Create Deployment script for all Multisigs that are required for the Roles/Actors in the system. |
danoctavian
approved these changes
Apr 7, 2024
|
good, strange that the imports in the scripts affected the final deploy content |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After deploying and trying to verify contract on etherscan, I got an error stating the Bytecode onchain didn't match what was being verified. So I looked into the contract in the deploy scripts and noticed there were unused contracts being deployed from
import * "some-contract";that were failing the etherscan verify script.Changed to Alias imports
This allows granular control over which contracts are being imported and prevents unused imports.