Fix audit issues 8.1 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #319: ChainSecurity Audit Findings Review. |
xhad
force-pushed
the
chad/sc-319/audit-8-1-fixes
branch
3 times, most recently
from
be81434 to
2a44e79
Compare
danoctavian
reviewed
Mar 30, 2024
xhad
force-pushed
the
chad/sc-319/audit-8-1-fixes
branch
from
2a44e79 to
ee471f0
Compare
Fix validators.length in registerValidators Fix validators.length 2x Revert validator length changes Gas optimization for validatorsLength Fix gas optimization for newValidators
xhad
force-pushed
the
chad/sc-319/audit-8-1-fixes
branch
from
ee471f0 to
b7dee5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.1.1 - Fixed + Version 2 Fixed
8.1.2 - Fixed
8.1.5 - Value used for event
8.1.6 - Fixed for ynLSD
8.1.8 - Fixed
8.1.9 - Fixed
8.1.10 - Fixed
8.1.11 - Fixed
Exceptions
8.1.3 - Decided not to fix
8.1.4 - Decided not to fix for readability concerns
8.1.7 - Do not understand the issue as described