Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ynETH Scenario Testing #42

Merged
merged 8 commits into from
Mar 23, 2024
Merged

Conversation

xhad
Copy link
Contributor

@xhad xhad commented Mar 16, 2024

This PR introduces a series of new test scenarios for the ynETH contract, aimed at rigorously evaluating its functionality and ensuring its robustness in various operational contexts.

  • Scenario 1: Successful ETH Deposit and Share Minting
    Objective: Test that a user can deposit ETH and receive the correct amount of shares in return.

  • Scenario 2: Deposit Paused
    Objective: Ensure that deposits are correctly paused and resumed, preventing or allowing ETH deposits accordingly.

  • Scenario 3: Deposit and Withdraw ETH to Staking Nodes Manager
    Objective: Test the end-to-end flow of depositing ETH to an eigenpod, and withdrawing ETH to the staking nodes manager.

  • Scenario 4: Share Accounting and Yield Accrual
    Objective: Verify that the share price correctly increases after the contract earns yield from consensus and execution rewards.

  • Scenario 5: Emergency Withdrawal of ETH
    Objective: Test ability to withdraw all assets from eigenpods.

  • Scenario 6: Validator and Staking Node Administration
    Objective: Test the ynETH's ability to update the address of the Staking Nodes Manager.

  • Scenario 7: Accrual and Distribution of Fees
    Objective: Ensure that ynETH correctly accrues and distributes fees from yield earnings from execution and consensus rewards.

  • Scenario 8: Staking Rewards Distribution
    Objective: Test the distribution of staking rewards to a multisig.

  • Scenario 9: EigenLayer Accounting and Distribution
    Objective: Verify that ynETH correctly accounts for fund balances and withdrawals from EigenLayer.

Copy link

This pull request has been linked to Shortcut Story #193: Add Scenario Based Testing for ynETH deposit flow.

@xhad xhad changed the base branch from main to release-candidate March 16, 2024 03:11
@xhad xhad requested a review from danoctavian March 16, 2024 03:17
@xhad xhad added the WIP label Mar 16, 2024
@xhad xhad force-pushed the chad/sc-193/yneth-spec-test-rebased branch from e88753a to c7895e3 Compare March 19, 2024 02:57
@xhad xhad force-pushed the chad/sc-193/yneth-spec-test-rebased branch from eaf49e3 to dc7f3e0 Compare March 23, 2024 21:28
@xhad xhad merged commit fdc503a into release-candidate Mar 23, 2024
1 check passed
@xhad xhad deleted the chad/sc-193/yneth-spec-test-rebased branch April 7, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant