Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-133] Oracle Branch Tests #24

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: [sc-133] Oracle Branch Tests #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11328f9
Adds Oracle branch test coverage
xhad Mar 5, 2024
6f18292
Format test
xhad Mar 5, 2024
94ab51c
Fix LSDStakingNode test
xhad Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/foundry/integration/LSDStakingNode.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ contract LSDStakingNodeTest is IntegrationBaseTest {

function testImplementationView() public {
address _implementation = lsdStakingNode.implementation();
assertEq(_implementation, address(lsdStakingNode));
vm.prank(actors.STAKING_NODE_CREATOR);
ynlsd.createLSDStakingNode();
xhad marked this conversation as resolved.
Show resolved Hide resolved
ILSDStakingNode _lsdStakingNode = ynlsd.nodes(0);
assertEq(_implementation, address(_lsdStakingNode.implementation()));
}

function testDepositAssetsToEigenlayerUnsupportedAsset() public {
Expand Down
122 changes: 115 additions & 7 deletions test/foundry/integration/YieldNestOracle.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import "./IntegrationBaseTest.sol";

// SPDX-License-Identifier: BSD 3-Clause License
pragma solidity 0.8.24;

import "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";
import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import "./IntegrationBaseTest.sol";
import {IERC20} from "@openzeppelin/contracts/interfaces/IERC20.sol";
import {AggregatorV3Interface} from "../../../src/external/chainlink/AggregatorV3Interface.sol";


contract YieldNestOracleTest is IntegrationBaseTest {
// ContractAddresses contractAddresses = new ContractAddresses();
// ContractAddresses.ChainAddresses public chainAddresses = contractAddresses.getChainAddresses(block.chainid);

error PriceFeedTooStale(uint256 age, uint256 maxAge);
function testSetAssetWithZeroAge() public {
vm.expectRevert(YieldNestOracle.ZeroAge.selector);
Expand Down Expand Up @@ -99,4 +99,112 @@ contract YieldNestOracleTest is IntegrationBaseTest {
assertEq(address(updatedPriceFeedAddress), newPriceFeedAddress, "Price feed address not updated correctly");
assertEq(updatedAge, newAge, "Age not updated correctly");
}
}

function setupIntializationTests(address[] memory assetAddresses, address[] memory priceFeeds, uint256[] memory maxAges)
public returns (YieldNestOracle, YieldNestOracle.Init memory) {
TransparentUpgradeableProxy yieldNestOracleProxy;
yieldNestOracle = new YieldNestOracle();
yieldNestOracleProxy = new TransparentUpgradeableProxy(address(yieldNestOracle), actors.PROXY_ADMIN_OWNER, "");
yieldNestOracle = YieldNestOracle(address(yieldNestOracleProxy));

IStrategy[] memory strategies = new IStrategy[](2);
address[] memory pauseWhitelist = new address[](1);
pauseWhitelist[0] = actors.TRANSFER_ENABLED_EOA;

strategies[0] = IStrategy(chainAddresses.lsd.RETH_STRATEGY_ADDRESS);
strategies[1] = IStrategy(chainAddresses.lsd.STETH_STRATEGY_ADDRESS);

YieldNestOracle.Init memory oracleInit = YieldNestOracle.Init({
assets: assetAddresses,
priceFeedAddresses: priceFeeds,
maxAges: maxAges,
admin: actors.ADMIN,
oracleManager: actors.ORACLE_MANAGER
});
return (yieldNestOracle, oracleInit);
}

function testInitializeAssetAddressesArraysLengthMismatch() public {
address[] memory assetAddresses = new address[](3);
address[] memory priceFeeds = new address[](2);
uint256[] memory maxAges = new uint256[](2);

assetAddresses[0] = chainAddresses.lsd.RETH_ADDRESS;
assetAddresses[1] = chainAddresses.lsd.STETH_ADDRESS;
assetAddresses[2] = chainAddresses.lsd.STETH_ADDRESS;
priceFeeds[0] = chainAddresses.lsd.RETH_FEED_ADDRESS;
priceFeeds[1] = chainAddresses.lsd.STETH_FEED_ADDRESS;
maxAges[1] = uint256(86400);
maxAges[0] = uint256(86400);

(YieldNestOracle oracle, YieldNestOracle.Init memory init) = setupIntializationTests(assetAddresses, priceFeeds, maxAges);
vm.expectRevert(
abi.encodeWithSelector(
YieldNestOracle.ArraysLengthMismatch.selector,
assetAddresses.length,
priceFeeds.length,
maxAges.length
)
);
oracle.initialize(init);
}

function testInitializeAssetMaxAgesLengthMismatch() public {
address[] memory assetAddresses = new address[](2);
address[] memory priceFeeds = new address[](2);
uint256[] memory maxAges = new uint256[](3);

assetAddresses[0] = chainAddresses.lsd.RETH_ADDRESS;
assetAddresses[1] = chainAddresses.lsd.STETH_ADDRESS;

priceFeeds[0] = chainAddresses.lsd.RETH_FEED_ADDRESS;
priceFeeds[1] = chainAddresses.lsd.STETH_FEED_ADDRESS;
maxAges[0] = uint256(86400);
maxAges[1] = uint256(86400);
maxAges[2] = uint256(86400);

(YieldNestOracle oracle, YieldNestOracle.Init memory init) = setupIntializationTests(assetAddresses, priceFeeds, maxAges);
vm.expectRevert(
abi.encodeWithSelector(
YieldNestOracle.ArraysLengthMismatch.selector,
assetAddresses.length,
priceFeeds.length,
maxAges.length
)
);
oracle.initialize(init);
}

function testInitializePriceFeedZeroAddress() public {
address[] memory assetAddresses = new address[](2);
address[] memory priceFeeds = new address[](2);
uint256[] memory maxAges = new uint256[](2);
assetAddresses[0] = chainAddresses.lsd.RETH_ADDRESS;
assetAddresses[1] = chainAddresses.lsd.STETH_ADDRESS;
priceFeeds[0] = address(0);
priceFeeds[1] = chainAddresses.lsd.STETH_FEED_ADDRESS;
maxAges[0] = uint256(86400);
maxAges[1] = uint256(86400);

(YieldNestOracle oracle, YieldNestOracle.Init memory init) = setupIntializationTests(assetAddresses, priceFeeds, maxAges);
vm.expectRevert(abi.encodeWithSelector(YieldNestOracle.ZeroAddress.selector));
oracle.initialize(init);
}

function testInitializeAssetZeroAddress() public {
address[] memory assets = new address[](2);
address[] memory priceFeeds = new address[](2);
uint256[] memory maxAges = new uint256[](2);
assets[0] = address(0);
assets[1] = address(0);
priceFeeds[0] = chainAddresses.lsd.RETH_FEED_ADDRESS;
priceFeeds[1] = chainAddresses.lsd.STETH_FEED_ADDRESS;
maxAges[0] = uint256(86400);
maxAges[1] = uint256(86400);

(YieldNestOracle oracle, YieldNestOracle.Init memory init) = setupIntializationTests(assets, priceFeeds, maxAges);
vm.expectRevert(abi.encodeWithSelector(YieldNestOracle.ZeroAddress.selector));
oracle.initialize(init);
}
}