feat: ynViewer upgrade #119
Conversation
src/ynViewer.sol
Outdated
| IynETH public ynETH; | ||
| IStakingNodesManager public stakingNodesManager; | ||
|
|
||
| IERC4626 public immutable ynETH; |
There was a problem hiding this comment.
ynETH is not a IERC4626 for now and may never be one, it doesn't break any of the logic here, but i'd rather not confuse.
Let's leave it with IynETH
src/ynViewer.sol
Outdated
| function getRate() external view returns (uint256) { | ||
| uint256 _totalSupply = ynETH.totalSupply(); | ||
| uint256 _totalAssets = ynETH.totalAssets(); | ||
| if (_totalSupply == 0 || _totalAssets == 0) return 0; |
There was a problem hiding this comment.
If any of these are 0 at the initial system state, the rate is actually 1.
Since ynETH:ETH starts as 1:1 and slowly decreases over time with appreciation.
src/ynViewer.sol
Outdated
| _data[i] = StakingNodeData({ | ||
| nodeId: _node.nodeId(), | ||
| ethBalance: _node.getETHBalance(), | ||
| eigenPodEthBalance: _eigenPod.nonBeaconChainETHBalanceWei(), |
There was a problem hiding this comment.
the meaning of this was intended to be:
address(_eigenPod).balance
src/ynViewer.sol
Outdated
| nodeId: _node.nodeId(), | ||
| ethBalance: _node.getETHBalance(), | ||
| eigenPodEthBalance: _eigenPod.nonBeaconChainETHBalanceWei(), | ||
| podOwnerShares: stakingNodesManager.strategyManager().stakerStrategyShares(address(_node), _node.beaconChainETHStrategy()), |
There was a problem hiding this comment.
Here the intention was:
EigenPodManager.podOwnerShares()
It's a good question if those are in sync beaconChainETHStrategy. not 100% sure.
What we are using in accounting in the prod logic is
EigenPodManager.podOwnerShares()
Let's use that
script/DeployViewer.s.sol
Outdated
| @@ -0,0 +1,28 @@ | |||
| // SPDX-License-Identifier: BSD 3-Clause License | |||
There was a problem hiding this comment.
call the file
deployYnViewer.s.sol
script/DeployViewer.s.sol
Outdated
| privateKey == 0 ? vm.envUint("PRIVATE_KEY") : privateKey; | ||
| vm.startBroadcast(privateKey); | ||
|
|
||
| viewer = new ynViewer(_chainAddresses.yn.YNETH_ADDRESS, _chainAddresses.yn.STAKING_NODES_MANAGER_ADDRESS); |
There was a problem hiding this comment.
make it proxy upradeable, like the other ones - reason is if we need to update logic to keep this address constant.
No description provided.