Merge pull request #30 from yieldnest/chad/sc-133/staking-nodes-manag…

…er-coverage Add test for Set Max Nodes on Staking Nodes Manager
yieldnest · Mar 6, 2024 · d526c95 · d526c95
2 parents b94a03b + 7673df9
commit d526c95
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/test/foundry/integration/StakingNodesManager.t.sol b/test/foundry/integration/StakingNodesManager.t.sol
@@ -8,11 +8,10 @@ import {IntegrationBaseTest} from "./IntegrationBaseTest.sol";
 import {IStakingNode} from "../../../src/interfaces/IStakingNode.sol";
 import {IEigenPod} from "../../../src/external/eigenlayer/v0.1.0/interfaces/IEigenPod.sol";
 import {IStakingNodesManager} from "../../../src/interfaces/IStakingNodesManager.sol";
-import "forge-std/console.sol";
-import "../../../src/StakingNodesManager.sol";
-import "../../../src/ynETH.sol";
-import "../mocks/TestStakingNodeV2.sol";
-import "../mocks/TestStakingNodesManagerV2.sol";
+import {StakingNodesManager} from "../../../src/StakingNodesManager.sol";
+import {ynETH} from "../../../src/ynETH.sol";
+import {TestStakingNodeV2} from "../mocks/TestStakingNodeV2.sol";
+import {TestStakingNodesManagerV2} from "../mocks/TestStakingNodesManagerV2.sol";
 
 
 contract StakingNodesManagerStakingNodeCreation is IntegrationBaseTest {
@@ -90,6 +89,15 @@ contract StakingNodesManagerStakingNodeCreation is IntegrationBaseTest {
         vm.expectRevert("AccessControlUnauthorizedAccount");
         stakingNodesManager.createStakingNode();
     }
+
+    function testSetMaxNodeCount() public {
+        uint256 initialMaxNodeCount = stakingNodesManager.maxNodeCount();
+        uint256 newMaxNodeCount = initialMaxNodeCount + 1;
+        vm.prank(actors.STAKING_ADMIN);
+        stakingNodesManager.setMaxNodeCount(newMaxNodeCount);
+        uint256 updatedMaxNodeCount = stakingNodesManager.maxNodeCount();
+        assertEq(updatedMaxNodeCount, newMaxNodeCount, "Max node count does not match expected value");
+    }
 }
 
 contract StakingNodesManagerStakingNodeImplementation is IntegrationBaseTest {
@@ -316,7 +324,6 @@ contract StakingNodesManagerRegisterValidators is IntegrationBaseTest {
     function testRegisterValidatorsWithInsufficientDeposit() public {
         address addr1 = vm.addr(100);
         vm.deal(addr1, 100 ether);
-        uint validatorCount = 1;
         uint depositAmount = 16 ether; // Insufficient deposit amount
         vm.prank(addr1);
         yneth.depositETH{value: depositAmount}(addr1);
@@ -423,7 +430,6 @@ contract StakingNodesManagerViews is IntegrationBaseTest {
 contract StakingNodesManagerMisc is IntegrationBaseTest {
 
     function testSendingETHToStakingNodesManagerShouldRevert() public {
-        uint256 initialBalance = address(stakingNodesManager).balance;
         uint256 amountToSend = 1 ether;
 
         // Send ETH to the StakingNodesManager contract