test(meson): fix SSLClientServerTest.* tests with OpenSSL 3.2.0
#1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows making some minor cleanups
Since OpenSSL commit <openssl/openssl@342e365>, the default X.509 certificate format generated with the `openssl req` command has been changed to X.509 v3 from X.509 v1. For some reason, this change breaks cpp-httplib's SSLClientServerTest.* tests. To fix the test failures, this patch passes the '-x509v1' flag instead of '-x509' when OpenSSL 3.2.0 or newer is detected. To detect the version of a command line utility, Meson 0.62.0 or later is required. Fixes <yhirose#1798>, but only for the Meson build system.
Tachi107
force-pushed
the
fix-tests-openssl-3.2-meson
branch
from
c151db4 to
f68af45
Compare
|
@Tachi107 thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #1798 when building with Meson, while also bumping the minimum required Meson version to 0.62.0. Please do not squash on merge!
Here are the descriptions of the two individual commits:
build(meson): bump minimum version to 0.62.0
This allows making some minor cleanups
test(meson): fix
SSLClientServerTest.*tests with OpenSSL 3.2.0Since OpenSSL commit openssl/openssl@342e365, the default X.509 certificate format generated with the
openssl reqcommand has been changed to X.509 v3 from X.509 v1.For some reason, this change breaks cpp-httplib's
SSLClientServerTest.*tests.To fix the test failures, this patch passes the
-x509v1flag instead of-x509when OpenSSL 3.2.0 or newer is detected. To detect the version of a command line utility, Meson 0.62.0 or later is required.Fixes #1798, but only for the Meson build system.