Test reading empty zero-length file

[paulharris]

I've also discovered mmap() will not map a zero byte file.
So current httplib cannot serve completely empty files.

I created a test case.

[yhirose]

Thanks!

[yhirose]

This test fails... (https://github.com/yhirose/cpp-httplib/actions/runs/10781876980/job/29900733140)

[paulharris]

Yes, was just a test case, did not include a fix.

…

On Tue, 10 Sept 2024, 7:20 am yhirose, ***@***.***> wrote: This test fails... ( https://github.com/yhirose/cpp-httplib/actions/runs/10781876980/job/29900733140 ) — Reply to this email directly, view it on GitHub <#1931 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMSAS4TPM2CMT6E5Q5VPDDZVYUKJAVCNFSM6AAAAABN3Y7PL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGMYTMOJYGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Tachi107]

The test failed because it expected the wrong header (text/plain as opposed to application/octet-stream). So, is cpp-httplib unable to serve empty files or was Paul's conclusion wrong?

[yhirose]

The test failed because it expected the wrong header (text/plain as opposed to application/octet-stream). So, is cpp-httplib unable to serve empty files or was Paul's conclusion wrong?

You are correct. cpp-httplib serves an empty files with application/octet-stream.

cpp-httplib/test/test.cc

Line 2923 in 6c93aea

EXPECT_EQ("application/octet-stream", res->get_header_value("Content-Type"));

[paulharris]

The test was originally hard-crashing due to trying to mmap an empty file.
This was fixed after this test was added, in 9f8db2c
which was addressing #1933, a related issue.
So now the test was able to progress further to where you saw it fail for a different reason.