Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_package for curl #1920

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix find_package for curl #1920

merged 1 commit into from
Sep 6, 2024

Conversation

bgs99
Copy link
Contributor

@bgs99 bgs99 commented Sep 6, 2024

Fixes the find_package call to point to the curl module provided by CMake (https://cmake.org/cmake/help/latest/module/FindCURL.html)

Without this change, building via CMake produces the following error:

  CMake Error at test/CMakeLists.txt:27 (find_package):
  By not providing "Findcurl.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "curl", but
  CMake did not find one.

  Could not find a package configuration file provided by "curl" with any of
  the following names:

    curlConfig.cmake
    curl-config.cmake

  Add the installation prefix of "curl" to CMAKE_PREFIX_PATH or set
  "curl_DIR" to a directory containing one of the above files.  If "curl"
  provides a separate development package or SDK, be sure it has been
  installed.

@bgs99
Copy link
Contributor Author

bgs99 commented Sep 6, 2024

As a side note, what do you think about adding a CMake (and also Meson, I guess) pipeline in CI?

At least just for building the tests without running them.

@yhirose yhirose merged commit eb6f610 into yhirose:master Sep 6, 2024
3 of 4 checks passed
@yhirose
Copy link
Owner

yhirose commented Sep 6, 2024

Thanks!

@bgs99 bgs99 deleted the cmake-curl branch September 6, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants