Performance: reserve body to avoid frequent reallocations and copies #1781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some profiling on a client application doing a lot of downloads, I realized my application spent ~13% of its time doing
std::string::append
(compiled with gcc and -03, even more when compiling in debug mode with -O1: ~30%).I realized this could be improved by reserving the output buffer (
res.body
) since we know the output size ifContent-Length
header is present.