Fix readbility-qualified-auto #1725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhirose
reviewed
Nov 24, 2023
httplib.h
Outdated
| @@ -2216,7 +2216,7 @@ inline bool from_hex_to_i(const std::string &s, size_t i, size_t cnt, | |||
| } | |||
|
|
|||
| inline std::string from_i_to_hex(size_t n) { | |||
| static const auto charset = "0123456789abcdef"; | |||
| static const auto *const charset = "0123456789abcdef"; | |||
There was a problem hiding this comment.
Adding const is ok, but I don't like to leave *, since I do the same for shared pointers as below.
auto mm = std::make_shared<detail::mmap>(path.c_str());There was a problem hiding this comment.
In the second case. mm is not a raw pointer, though. Here, I could change the pointer to either a C-style array or an std::array. I'll try a few things to see which one would be more elegant and still be compliant.
There was a problem hiding this comment.
My saying is that I would like to keep the code as always using just auto regardless of regular value, raw pointer or managed pointer (std::shared_ptr, std::unique_ptr). Thanks for your effort, but I'l close it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.