Add EINTR and EAGAIN judge for accept #1438
Conversation
|
@fishpenguin thanks for the pull request. Could you explain more about EAGAIN? In what situation did you receive EAGAIN? |
|
@yhirose I didn't meet EAGAIN error, it usually happens when the socket network resource temporarily unavailable. EAGAIN shouldn't be treat as an error, it won't destroy socket. When EAGAIN happens, socket should retry as man accept said. |
|
@fishpenguin, thank you for the reply. Could you add at least one unit test case to validate your modification works? Then, I'll do code review. Thanks! |
|
@fishpenguin any response? |
|
@yhirose sorry, I was busy with other things these days and forgot this pr. I added a unit test: the unit test send SIGINT to the thread which is in listening, and the listen_after_bind() won't quit. If the EINTR isn't judged, it will quit when receive the signal. |
|
@fishpenguin thanks for adding the unit test. Could you take a look at the build error on GitHub Action? |
|
@fishpenguin thanks for the fine contribution! |
* Add EINTR and EAGAIN judge for accept * Add EINTR signal tests * Cancel win32 and win64 compile on signal unittest Co-authored-by: yukun.yu <[email protected]>
This pr add EINTR and EAGAIN process for socket accept function.
When program is blocked by accept, Capturing some signals like SIGUSR2 may interrupt the accept and return error(-1), set errno to EINTR. When this happens, http service shouldn't be shutdown but should continue to call accept.
I propose this pr because I met such problem, I want to shutdown my http service by stop function when I capture signals, but this will shutdown straightly.