Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Accept-Encoding header for the client #1975

Closed
Yogurt4 opened this issue Nov 13, 2024 · 2 comments
Closed

Default Accept-Encoding header for the client #1975

Yogurt4 opened this issue Nov 13, 2024 · 2 comments

Comments

@Yogurt4
Copy link

Yogurt4 commented Nov 13, 2024

Suggestion: httplib::Client could set a default Accept-Encoding header automatically, based on the compile options, like

#if defined CPPHTTPLIB_ZLIB_SUPPORT
		{ "Accept-Encoding", "gzip, deflate" }
#endif

(plus the combinations with Brotli).

It's quite trivial to implement. Shall I provide a pull request though?

@yhirose
Copy link
Owner

yhirose commented Nov 14, 2024

@Yogurt4 I implemented it. Thanks for the suggestion!

yhirose added a commit that referenced this issue Nov 15, 2024
@Yogurt4
Copy link
Author

Yogurt4 commented Nov 15, 2024

Wow! Thanks for the superfast response, and for implenting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants