fix: explicitly handle async JavaScript failures. #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit checks for errors by validating the result code coming from the C Client.
Description
All calls to methods in the promisified version of the JavaScript client has now an explicit result code check. A result code that has a negative value is a failure, and the method will from now on perform a
reject
.Before this, errors failed silently, as described in issue #237 - the issue is about the
set
method, but the error exists in all promisified method calls.Motivation and Context
fixes #237
How Has This Been Tested?
npm tests passed
CircleCI passed
added example code that verifies the behaviour.
Types of changes
Checklist: