Node.js 10 support #142
Merged
Node.js 10 support #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Node.js 10 is now LTS and the current node-zookeeper project won't be able to build when running that version. This PR will solve it. Ref: nodejs/node#23159 |
|
Hi @yfinkelstein! Any chance of getting this pull request reviewed? |
|
ping @mdlavin |
|
The code changes look good to me. Can you update the |
|
Great! I'll set up Travis CI in my fork and will push updates to the configuration when it's ready! |
|
@mdlavin Done! Travis build is green. |
|
Looks great. I'll merge and publish a new version |
|
The new version is published. I'd love if you could confirm the published version works for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npm installfails when using Node version 10. (v10.11.0).This Pull Request fixes the issues with the removed
v8_debug.hand warnings from npm about old packages.Also, I have replaced the deprecated
ForceSetwithDefineOwnPropertyaccording to conversations in the Nan repo, issue nodejs/nan#707