feat: Migrate Input types to uischema (TextInput, NumberInput, ...) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
changed the title
* Add LSP of LG
* change folder name
* change folder location
* seperate server and client demo
* add completion and hover for builtin-functions
* change file names
* change dependency
* refactor the package
* update demo readme
* make some refine
* remove npm lock file
* add demos to workspace and run test in 1 command
* remove declaration files
* change tsc outDir to dist, simplify test command
* add syntax highlight in demo and new API
* change naming of the project and move the demo
* remove package.json in demo
* change the content in readme
* fix lg-lsp package publish problem
* fix build command and redundent d.ts files
* integrate LG LSP server to composer server
* change api in demo
* change the order of commands in build:prod
* delete redundent files generated from build
* change lg-lsp-server api to attachLSPServer
* remove gitignore in lg-lsp-server demo
* remove attachLSPServer in server
* fix token rules and suggestion context awareness
* init of LU LSP
* add diagnostic in LSP
* add auto suggestions
* fix
* remove redundent in client
* add doc on type config
* fix
* modify doc type format
* fix
* change version of bf-lu
* fix diagnostic
* refactor getRangeAtPosition method
* fix tokens
* remove black line
* fix tokens
* add roles suggestions
* add regex entity seperated line definition
* add suggestions for ml entity
* matching only ML entities
* fix
* update documents
* fix
* integrate lu-lsp to composer
* upgrade botbuilder-expressions
* clean up
* update sample
* add test
* add syntax highlight
* add token rule for {@ expr
* add a case in token
* fix import statement token
* fix composite entity auto complete
* fix entity suggestion and tokens
* add labeling experience of add unlabeled entity
* fix typos
* fix lint
* fix redundent edits
* fix unnecessary space
* fix naming and role suggestions
* fix labeling and error postion
* fix insert text in wrong line, intent usesFeature
* update bf-lu version
* change find a valid luisJson and suggest composite
* add unit test for LU lsp basic funcionalities
Co-authored-by: Hongyang Du (hond) <hond@microsoft.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
…icrosoft#1868) * add user defined property * add some comments * add unit test * update some naming Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
…Wrapper) (microsoft#1873) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
* inline lg editor undo and redo * add forceUpdate for undo/redo * support the lg undo * update the lg to store directly * fix unit test * fix some comments * register api to extension * add some comments * update the sync logic * revert some code * update the type Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
yeze322
pushed a commit
that referenced
this pull request
Apr 9, 2020
* extract visual editor from design page * bump shared packages * add botframework-ui dependencies * extract property editor from design page * don't pass rootPath as a prop * [wip] use adaptive form package * don't hoist botframework-ui packages * start stubbing out sync based new shell api * bump prompts plugin * revert to using shell extension container to render new form * add extension and adaptive form packages * update jest config to include display name * import json and prompts plugins * convert code editor to @monaco-editor package * render string field for expressions * remove height transition when there is an error * feat: Added select dialog ui plugin (#1) * feat: Added select dialog ui plugin * Apply suggestions from code review * Added tests * Clean up * Updated tests * renamed directory to select-dialog Co-authored-by: Andy Brown <asbrown002@gmail.com> * enable json ui plugin * allow customization of $role and $kind fields * [wip] begin lg editor field * fix height calculation * fix: Set default value in StringField to an empty string (#2) * use field name for lg fields * ignore lg lib * refactor plugin config add roleSchema and kindSchema * clean up lg plugin dependencies * drop ui prefix for ui options * bump @types/react and @types/react-dom * initial support of recognizers in plugin config * initial lu ui plugin * fix: Fixed object array border conflict (#3) * fix: Fixed object array border conflict * Modified getUISchema function * Resolve build errors * Fixed uiOptions in SchemaField * Reverted changes to getUISchema * [wip] start work on rendering better descriptions and help links * finish rendering description and help links * re-renable custom keybinding * clean up old bfcomposer monaco editor bits * fix build errors * do not enable minimap by default * feat: Add Select Dialog Plugin * Updated defaultUiSchema * Added select dialog plugin * fixed issue in uiSchema * Fixed luIntentOptions * Added help link * Modified tests * Fixed tests * move shared types from indexers to shared * fix merge issue * fix lint error * do not compile with test files * move prompt settings to 'Other' tab * fix: Moved prompt settings to 'Other' tab * fix: prompt settings styling and description * wrap labels in formatMessage Co-authored-by: Andy Brown <asbrown002@gmail.com> * move globally hidden fields to getOrderedProperties * [wip] add ability to have multi field rows * make sure to pass value to form rows * use json schema version 7 for base typings * add one of field * begin work on expression editor * update prompt plugin to use json schema v 7 * feat: Updated FormRow to support multiple fields in a row * feat: Updated FormRow to support multiple fields in a row * Updated FormRow * Updated FormRow * fix problem with yarn install * bump react versions * fix merge conflicts * correctly hide placeholder in code editor * remove inline recognizer editor * remove select intent plugin * add key to editor to force remounting * handle type and oneOf expression schemas * port inline luis intent editor * memoize initial value * rename lu plugin to luis * port regex intent editor * fix: Moved type selector to be inline with label (#7) * fix: Fixed warning related to link navigation styling (#8) * rename handleChange to handleRecognizerChange * add method to recognizer config to determine if selected * refactor code editors to not have dependency on monaco-editor package directly * downgrade monaco-languageclient There is an error initializing the language services * export OnInit type * clean up monaco dependencies * update sample schema * render all other fields on single row sets up support for defaultValue exression editor * render json editor with selected schema for complex types * feat: Added custom array field for set properties * feat: Added stackArrayItems to UiOptions * fix: Fixed array item borders * add designerId to ShellData formContext.dialogId is actually data.$designer.id which is confusing when there is dialogId in the ShellData. * feat: Updated ObjectArrayField to display complex arrays in a stacked layout * fix: Filtered object array properties to reflect ui order * removed console.log * fix: Fixed ExpressionField flicker * feat: Added add button for stacked array items * add schema prop to json editor * updated defautUiSchema.ts * register schemas on a per-model basis * fix merge build issue * trigger intent field change when editor changes * fix: Added 'expression' to expression type dropdown. * add disabled item actions for new array item * reduce height of lg field * pass raw errors to schema field child * plumb errors through the prompt form * fix array item styles when an error is present * use label overrides from ConceptLabels in form title * pass project id to lg editor * fix: Added 'expression' to type selector * implement arrayitem wrapper for array fields * fix: Added helpLinks to defaultUiSchema * add useArrayItems hook for array fields * fix: Added 'expression' to type selector * fix: added 'expression' to type dropdown * fix: combined 'selectedSchema' and 'selectedKey' into 'selectedOption' * feat: Added inline lu to prompts * do not override descriptions for prompt fields * fix array item usage * support expression fields with object properties * add subtitle to uiSchema * add titles to choices and confirmChoices * do not use label overrides in form title * [wip] use schema field to render all input fields * update ui schema * correctly set selected option * fix: fixed array item styles * feat: added formatData to uiOptions * fix: Added formatData to ObjectArrayField * default to correct type in expression editor * start case the fallback labels * allow labels for objects with properties * combine choice input and confirm input components * handle enum expressions * feat: Removed formatData in favor of serializer * fix: Fixed serializer labeling * Updated jest.config.js * fix: fixed recognizer in prompts * fix: fixed getSelectedOption returning expression option for strings * fix unit tests * Removed select intent * Fixed luis handleRecognizerChange method * fix merge issue * fixed error message displaying next to field in an array * removed kindSchema comments * update error message when recognizer can't be determined * add testid to expression dropdown * fix todo spec * fix notifications page spec * remove obiformeditor package * fix new LGTM alerts * incorporate locale when setting lg file name * fix selecting correct lu file with locale * sync data with shell to support undo/redo * update oneOf field to handle array of types * do not use transparent border for one of fields * do not have transparent border for expression editor It looks weird with the prefix icon * fix: Fixed dropdownWidth in expressions * fix: Fixed inline array styling * fix: removed unused variable * fix: Fixed lint issue * get localize lu file for inline intent editor * fix: Fixed error rendering issue * fix: Fixed schema field styles Co-authored-by: TJ Durnford <tjdford@gmail.com>
yeze322
pushed a commit
that referenced
this pull request
Jan 27, 2021
Adapt undo/redo functions to Electron app menu
yeze322
pushed a commit
that referenced
this pull request
Jan 27, 2021
* feat: Added select dialog ui plugin * Apply suggestions from code review * Added tests * Clean up * Updated tests * renamed directory to select-dialog Co-authored-by: Andy Brown <asbrown002@gmail.com>
yeze322
pushed a commit
that referenced
this pull request
Jul 20, 2021
* extract visual editor from design page * bump shared packages * add botframework-ui dependencies * extract property editor from design page * don't pass rootPath as a prop * [wip] use adaptive form package * don't hoist botframework-ui packages * start stubbing out sync based new shell api * bump prompts plugin * revert to using shell extension container to render new form * add extension and adaptive form packages * update jest config to include display name * import json and prompts plugins * convert code editor to @monaco-editor package * render string field for expressions * remove height transition when there is an error * feat: Added select dialog ui plugin (#1) * feat: Added select dialog ui plugin * Apply suggestions from code review * Added tests * Clean up * Updated tests * renamed directory to select-dialog Co-authored-by: Andy Brown <asbrown002@gmail.com> * enable json ui plugin * allow customization of $role and $kind fields * [wip] begin lg editor field * fix height calculation * fix: Set default value in StringField to an empty string (#2) * use field name for lg fields * ignore lg lib * refactor plugin config add roleSchema and kindSchema * clean up lg plugin dependencies * drop ui prefix for ui options * bump @types/react and @types/react-dom * initial support of recognizers in plugin config * initial lu ui plugin * fix: Fixed object array border conflict (#3) * fix: Fixed object array border conflict * Modified getUISchema function * Resolve build errors * Fixed uiOptions in SchemaField * Reverted changes to getUISchema * [wip] start work on rendering better descriptions and help links * finish rendering description and help links * re-renable custom keybinding * clean up old bfcomposer monaco editor bits * fix build errors * do not enable minimap by default * feat: Add Select Dialog Plugin * Updated defaultUiSchema * Added select dialog plugin * fixed issue in uiSchema * Fixed luIntentOptions * Added help link * Modified tests * Fixed tests * move shared types from indexers to shared * fix merge issue * fix lint error * do not compile with test files * move prompt settings to 'Other' tab * fix: Moved prompt settings to 'Other' tab * fix: prompt settings styling and description * wrap labels in formatMessage Co-authored-by: Andy Brown <asbrown002@gmail.com> * move globally hidden fields to getOrderedProperties * [wip] add ability to have multi field rows * make sure to pass value to form rows * use json schema version 7 for base typings * add one of field * begin work on expression editor * update prompt plugin to use json schema v 7 * feat: Updated FormRow to support multiple fields in a row * feat: Updated FormRow to support multiple fields in a row * Updated FormRow * Updated FormRow * fix problem with yarn install * bump react versions * fix merge conflicts * correctly hide placeholder in code editor * remove inline recognizer editor * remove select intent plugin * add key to editor to force remounting * handle type and oneOf expression schemas * port inline luis intent editor * memoize initial value * rename lu plugin to luis * port regex intent editor * fix: Moved type selector to be inline with label (#7) * fix: Fixed warning related to link navigation styling (#8) * rename handleChange to handleRecognizerChange * add method to recognizer config to determine if selected * refactor code editors to not have dependency on monaco-editor package directly * downgrade monaco-languageclient There is an error initializing the language services * export OnInit type * clean up monaco dependencies * update sample schema * render all other fields on single row sets up support for defaultValue exression editor * render json editor with selected schema for complex types * feat: Added custom array field for set properties * feat: Added stackArrayItems to UiOptions * fix: Fixed array item borders * add designerId to ShellData formContext.dialogId is actually data.$designer.id which is confusing when there is dialogId in the ShellData. * feat: Updated ObjectArrayField to display complex arrays in a stacked layout * fix: Filtered object array properties to reflect ui order * removed console.log * fix: Fixed ExpressionField flicker * feat: Added add button for stacked array items * add schema prop to json editor * updated defautUiSchema.ts * register schemas on a per-model basis * fix merge build issue * trigger intent field change when editor changes * fix: Added 'expression' to expression type dropdown. * add disabled item actions for new array item * reduce height of lg field * pass raw errors to schema field child * plumb errors through the prompt form * fix array item styles when an error is present * use label overrides from ConceptLabels in form title * pass project id to lg editor * fix: Added 'expression' to type selector * implement arrayitem wrapper for array fields * fix: Added helpLinks to defaultUiSchema * add useArrayItems hook for array fields * fix: Added 'expression' to type selector * fix: added 'expression' to type dropdown * fix: combined 'selectedSchema' and 'selectedKey' into 'selectedOption' * feat: Added inline lu to prompts * do not override descriptions for prompt fields * fix array item usage * support expression fields with object properties * add subtitle to uiSchema * add titles to choices and confirmChoices * do not use label overrides in form title * [wip] use schema field to render all input fields * update ui schema * correctly set selected option * fix: fixed array item styles * feat: added formatData to uiOptions * fix: Added formatData to ObjectArrayField * default to correct type in expression editor * start case the fallback labels * allow labels for objects with properties * combine choice input and confirm input components * handle enum expressions * feat: Removed formatData in favor of serializer * fix: Fixed serializer labeling * Updated jest.config.js * fix: fixed recognizer in prompts * fix: fixed getSelectedOption returning expression option for strings * fix unit tests * Removed select intent * Fixed luis handleRecognizerChange method * fix merge issue * fixed error message displaying next to field in an array * removed kindSchema comments * update error message when recognizer can't be determined * add testid to expression dropdown * fix todo spec * fix notifications page spec * remove obiformeditor package * fix new LGTM alerts * incorporate locale when setting lg file name * fix selecting correct lu file with locale * sync data with shell to support undo/redo * update oneOf field to handle array of types * do not use transparent border for one of fields * do not have transparent border for expression editor It looks weird with the prefix icon * fix: Fixed dropdownWidth in expressions * fix: Fixed inline array styling * fix: removed unused variable * fix: Fixed lint issue * get localize lu file for inline intent editor * fix: Fixed error rendering issue * fix: Fixed schema field styles Co-authored-by: TJ Durnford <tjdford@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
If this is a bug fix, please describe the root cause and analysis of this problem.
Task Item
Please include a link to the related issue. Ex.
Closes #<issue #>Type of change
Please delete options that are not relevant.
Checklist
Screenshots
Please include screenshots or gifs if your PR include UX changes.