Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Default for VNode #672

Merged
merged 2 commits into from
Sep 30, 2019
Merged

Implement Default for VNode #672

merged 2 commits into from
Sep 30, 2019

Conversation

hgzimmerman
Copy link
Member

This is can provide ergonomic benefits by enabling .unwrap_or_default() to be called on Option<Html<Self>>, which might reduce the pain of having to write else {html!{}} blocks.

@jstarry jstarry self-requested a review September 30, 2019 02:13
jstarry
jstarry approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I had in mind 👍

@jstarry jstarry merged commit 933f666 into yewstack:master Sep 30, 2019
jstarry pushed a commit that referenced this pull request Oct 13, 2019
@hgzimmerman @jstarry
Implement Default for VNode (#672)
2f9557e 
* implement Default for VNode

* cargo fmt
llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
@hgzimmerman @llebout
Implement Default for VNode (yewstack#672)
d2f5c0a 
* implement Default for VNode

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarry jstarry jstarry approved these changes

Assignees
No one assigned
Labels
ergonomics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgzimmerman @jstarry