Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the rust-yew vscode plugin to the yew docs #3116

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

ttax00
Copy link
Contributor

@ttax00 ttax00 commented Feb 5, 2023

Description

This PR added links to the Rust Yew extension, providing some html! macro feature support, on VSCode marketplace and github repository; Per @WorldSEnder 's request.
Closes ttax00/code-yew-server#13

Checklist

  • I have reviewed my own code
  • I have added tests

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Visit the preview URL for this PR (updated for commit 5939cc3):

https://yew-rs--pr3116-master-7b8tqxms.web.app

(expires Sun, 12 Feb 2023 14:11:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There's one thing I will ask: please mention that it is a community maintained extension

@ttax00
Copy link
Contributor Author

ttax00 commented Feb 5, 2023

Thanks for the PR! There's one thing I will ask: please mention that it is a community maintained extension
How about now? 😮

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep you waiting so long, thesis is really keeping me busy. Looks good to me, too, thanks for your project!

@WorldSEnder WorldSEnder merged commit 47b60ec into yewstack:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the vscode plugin to the yew docs
3 participants