Attempt to fix recursion on display #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember looking at this exact line of code and thinking something was off but didn't put it together at the time :) |
siku2
approved these changes
Nov 15, 2021
ranile
approved these changes
Nov 16, 2021
|
I didn't even realize how this could go wrong. Good catch |
mc1098
approved these changes
Nov 16, 2021
Why didn't your approval count O.o |
I don't have write access to the repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make Display on AttrValue non-recursive
Fixes #2148
Checklist
cargo make pr-flow