Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust version for macro tests to 1.51 & enable const generics tests #1801

Merged
merged 6 commits into from
Mar 30, 2021
Merged

Update Rust version for macro tests to 1.51 & enable const generics tests #1801

merged 6 commits into from
Mar 30, 2021

Conversation

ranile
Copy link
Member

@ranile ranile commented Mar 30, 2021 •
edited
Loading

Description

This PR:

  • Updates Rust version for macro tests to 1.51
  • Enables const generics component tests for yew-functional-macro
  • Applies Clippy and Rustfmt fixes

Fixes #1766

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests
    (Non applicable)

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 0c795b8):

https://yew-rs--pr1801-const-generic-test-re538dy9.web.app

(expires Tue, 06 Apr 2021 13:30:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile
Copy link
Member Author

ranile commented Mar 30, 2021

The html! macro fails like this. This seems like a bug in the macro but I'm not what's causing it and how to fix it. Any ideas?

@siku2
Copy link
Member

siku2 commented Mar 30, 2021

The html! macro fails like this. This seems like a bug in the macro but I'm not what's causing it and how to fix it. Any ideas?

Haha, take a close look at the amount of angle brackets :D

@ranile
Copy link
Member Author

ranile commented Mar 30, 2021

The html! macro fails like this. This seems like a bug in the macro but I'm not what's causing it and how to fix it. Any ideas?

Haha, take a close look at the amount of angle brackets :D

Oh wow, I never noticed that...

@ranile ranile force-pushed the const-generic-test branch 2 times, most recently from 33f1c0b to c75571a Compare March 30, 2021 14:50
@ranile ranile marked this pull request as ready for review March 30, 2021 15:03
siku2
siku2 reviewed Mar 30, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/yew/src/format/nothing.rs
@@ -7,6 +7,7 @@ use anyhow::bail;
#[derive(Debug)]
pub struct Nothing;

#[allow(clippy::from_over_into)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why didn't you change it here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this error-ed out instead of creating an instance in Into whereas it actually created an instance in From. Let me know if this should be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah well, let's just roll with it then.

@siku2 siku2 merged commit 991abab into yewstack:master Mar 30, 2021
cecton pushed a commit to siku2/yew that referenced this pull request Apr 25, 2021
@ranile @cecton
Update Rust version for macro tests to 1.51 & enable const generics t…
9728825 
…ests (yewstack#1801)

* update rust version for macro test to 1.51

* enable const generic tests

* run integration tests using MSRV

* am blind

* clippy, fmt

* apply suggestion
@cecton cecton mentioned this pull request Apr 25, 2021
Merged
2 tasks
@voidpumpkin voidpumpkin added A-yew-macro Area: The yew-macro crate A-yew-router Area: The yew-router crate labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siku2 siku2 siku2 left review comments

Assignees
No one assigned
Labels
A-yew-macro Area: The yew-macro crate A-yew-router Area: The yew-router crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable const generics component tests for yew-functional-macro
3 participants
@ranile @siku2 @voidpumpkin