Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace #[to="..."] attribute with #[at="..."] attribute. #1717

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

teymour-aldridge
Copy link
Contributor

Description

Enables use of an attribute called "at" as well as "to" in the router crate. I've left the "to" attribute in for now to avoid causing breaking changes.

Goes some way towards addresssing: #1107 (comment)

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests (well I've modified some of the existing ones)

@github-actions
Copy link

github-actions bot commented Jan 25, 2021

Visit the preview URL for this PR (updated for commit 435c502):

https://yew-rs--pr1717-replace-to-with-at-r0kwcqku.web.app

(expires Mon, 01 Feb 2021 16:45:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@siku2 siku2 added the A-yew-router Area: The yew-router crate label Jan 27, 2021
@teymour-aldridge
Copy link
Contributor Author

Is there anyone able to review this?

Copy link
Member

@siku2 siku2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I haven't checked whether there's still a leftover to in there but that wouldn't be the end of the world anyway.

@siku2 siku2 merged commit e0be985 into yewstack:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-router Area: The yew-router crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants