-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out stdweb #1697
Merged
jstarry
merged 4 commits into
yewstack:master
from
philip-peterson:peterson/rip-out-stdweb
Jan 23, 2021
Merged
Rip out stdweb #1697
jstarry
merged 4 commits into
yewstack:master
from
philip-peterson:peterson/rip-out-stdweb
Jan 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should include all the code changes now. Documentation will require a second pass (I'd propose for us to put that in another PR). |
Visit the preview URL for this PR (updated for commit ac253c1): https://yew-rs--pr1697-peterson-rip-out-std-uxpfudx9.web.app (expires Sat, 30 Jan 2021 16:11:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
philip-peterson
force-pushed
the
peterson/rip-out-stdweb
branch
from
January 13, 2021 17:57
108f952
to
b15e44a
Compare
philip-peterson
force-pushed
the
peterson/rip-out-stdweb
branch
from
January 18, 2021 21:39
b15e44a
to
695fc82
Compare
jstarry
force-pushed
the
peterson/rip-out-stdweb
branch
2 times, most recently
from
January 23, 2021 15:00
64403c1
to
fef1fa3
Compare
jstarry
force-pushed
the
peterson/rip-out-stdweb
branch
from
January 23, 2021 15:58
6997c84
to
148296a
Compare
Bye bye |
voidpumpkin
added
A-yew
Area: The main yew crate
A-yew-macro
Area: The yew-macro crate
labels
Nov 26, 2021
You will be missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #1569, v0.18 will be the last release beholden to stdweb. As a result, and also because it makes SSR work easier, this PR removes support to stdweb.
Checklist
cargo make pr-flow