Optimize VTag construction, memory footprint and patching (#1947)

* yew-macro: optimize VTag construction in html! macro * yew/vtag: decrease VTag memory footpting and construction args * yew,yew-macro: optimize VTag contruction, memory footprint and diffing * yew/vlist: revert to VTag boxing * yew-macro: add clippy allow for nightly rust * yew-macro: fix allow namespace * *: bump MSRV to 1.49.0 * yew/vnode: restore == for VTag comparison * yew/vtag: clean up reference casting * yew-macro/html_element: fix error span regression
yewstack · Jul 18, 2021 · d89f1cc · d89f1cc
1 parent 2412a68
commit d89f1cc
Show file tree

Hide file tree

Showing 14 changed files with 839 additions and 466 deletions.
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -113,7 +113,7 @@ jobs:
     strategy:
       matrix:
         toolchain:
-          - 1.45.0 # MSRV
+          - 1.49.0 # MSRV
           - stable
 
     steps:

diff --git a/Makefile.toml b/Makefile.toml
@@ -36,7 +36,7 @@ run_task = { name = ["lint-flow"], fork = true }
 category = "Testing"
 description = "Run all tests"
 dependencies = ["tests-setup"]
-env = { CARGO_MAKE_WORKSPACE_SKIP_MEMBERS = ["**/examples/*"] }
+env = { CARGO_MAKE_WORKSPACE_SKIP_MEMBERS = ["**/examples/*", "**/packages/changelog"] }
 run_task = { name = ["test-flow", "doc-test-flow"], fork = true }
 
 [tasks.benchmarks]

diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@
     <a href="https://docs.rs/yew/"><img alt="API Docs" src="https://img.shields.io/badge/docs.rs-yew-green"/></a>
     <a href="https://discord.gg/VQck8X4"><img alt="Discord Chat" src="https://img.shields.io/discord/701068342760570933"/></a>
     <a href="https://gitlocalize.com/repo/4999/whole_project?utm_source=badge"> <img src="https://gitlocalize.com/repo/4999/whole_project/badge.svg" /> </a>
-    <a href="https://blog.rust-lang.org/2020/07/16/Rust-1.45.0.html"><img alt="Rustc Version 1.45+" src="https://img.shields.io/badge/rustc-1.45%2B-lightgrey.svg"/></a>
+    <a href="https://blog.rust-lang.org/2020/12/31/Rust-1.49.0.html"><img alt="Rustc Version 1.49.0+" src="https://img.shields.io/badge/rustc-1.49%2B-lightgrey.svg"/></a>
   </p>
 
   <h4>

diff --git a/examples/futures/src/markdown.rs b/examples/futures/src/markdown.rs
@@ -53,9 +53,20 @@ pub fn render_markdown(src: &str) -> Html {
                     pre.add_child(top.into());
                     top = pre;
                 } else if let Tag::Table(aligns) = tag {
-                    for r in top.children.iter_mut() {
+                    for r in top
+                        .children_mut()
+                        .iter_mut()
+                        .map(|ch| ch.iter_mut())
+                        .flatten()
+                    {
                         if let VNode::VTag(ref mut vtag) = r {
-                            for (i, c) in vtag.children.iter_mut().enumerate() {
+                            for (i, c) in vtag
+                                .children_mut()
+                                .iter_mut()
+                                .map(|ch| ch.iter_mut())
+                                .flatten()
+                                .enumerate()
+                            {
                                 if let VNode::VTag(ref mut vtag) = c {
                                     match aligns[i] {
                                         Alignment::None => {}
@@ -68,7 +79,12 @@ pub fn render_markdown(src: &str) -> Html {
                         }
                     }
                 } else if let Tag::TableHead = tag {
-                    for c in top.children.iter_mut() {
+                    for c in top
+                        .children_mut()
+                        .iter_mut()
+                        .map(|ch| ch.iter_mut())
+                        .flatten()
+                    {
                         if let VNode::VTag(ref mut vtag) = c {
                             // TODO
                             //                            vtag.tag = "th".into();