apply code review suggestions

yewstack · Jul 16, 2021 · d46598e · d46598e
1 parent 75e6b08
commit d46598e
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/yew-macro/src/html_tree/lint/mod.rs b/packages/yew-macro/src/html_tree/lint/mod.rs
@@ -59,15 +59,13 @@ impl Lint for AHrefLint {
             };
             if let Some(prop) = get_attribute(&element.props, "href") {
                 if let syn::Expr::Lit(lit) = &prop.value {
-                    if let syn::Lit::Str(str) = &lit.lit {
-                        if str.value() == "#" {
+                    if let syn::Lit::Str(href) = &lit.lit {
+                        if href.value() == "#" {
                             emit_warning!(
                                 lit.span(),
                                 "'#' is not a suitable value for the `href` attribute. \
                                         Without a meaningful attribute assistive technologies \
-                                        will struggle to understand your webpage. (hint: use a \
-                                        tag other than `<a>` here or `javascript:void(0)` for \
-                                        the `href` attribute)"
+                                        will struggle to understand your webpage."
                             )
                         }
                     }