fix fuck up

yewstack · Feb 22, 2022 · 832cfba · 832cfba
1 parent 8be6eec
commit 832cfba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/yew-macro/src/props/component.rs b/packages/yew-macro/src/props/component.rs
@@ -112,7 +112,7 @@ impl ComponentProps {
                 let mut set_props = vec![];
                 let mut global_props = vec![];
                 for Prop { label, value, .. } in self.props.iter() {
-                    if shared.contains(&label.to_string()) {
+                    if is_element && shared.contains(&label.to_string()) {
                         global_props.push(quote_spanned! {value.span()=>
                             .#label(#value)
                         })
@@ -137,9 +137,9 @@ impl ComponentProps {
 
                 quote_spanned! {props_ty.span()=>
                     <#props_ty as ::yew::html::Properties>::builder()
+                        #globals_setter
                         #(#set_props)*
                         #set_children
-                        #globals_setter
                         .build()
                 }
             }