Skip to content

Commit

Permalink
we don't build typings for <html>
Browse files Browse the repository at this point in the history
It clashes with export of html! macro and it's basically never used in code anyway
  • Loading branch information
ranile committed Jan 23, 2022
1 parent 507c2ee commit 4a885d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 2 additions & 0 deletions packages/yew/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,8 @@ pub mod prelude {
pub use crate::suspense::Suspense;

pub use crate::functional::*;

pub use crate::virtual_dom::typings::*;
}

pub use self::prelude::*;
Expand Down
8 changes: 0 additions & 8 deletions packages/yew/src/virtual_dom/typings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ use crate::macros::generate_element;
use crate::virtual_dom::{AttrValue, Key, Listener, VNode};
use crate::{NodeRef};


generate_element! {
html;
props: {
manifest: AttrValue,
}
}

generate_element! {
base;
props: {
Expand Down

1 comment on commit 4a885d4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yew master branch benchmarks (Lower is better)

Benchmark suite Current: 4a885d4 Previous: 38021e3 Ratio
yew-struct-keyed 01_run1k 238.9785 234.656 1.02
yew-struct-keyed 02_replace1k 252.783 237.4175 1.06
yew-struct-keyed 03_update10th1k_x16 467.0045 394.1925 1.18
yew-struct-keyed 04_select1k 93.6815 75.9405 1.23
yew-struct-keyed 05_swap1k 130.46949999999998 107.9565 1.21
yew-struct-keyed 06_remove-one-1k 43.721 34.7085 1.26
yew-struct-keyed 07_create10k 2625.035 2313.8295 1.13
yew-struct-keyed 08_create1k-after1k_x2 549.89 447.7525 1.23
yew-struct-keyed 09_clear1k_x8 223.337 217.9425 1.02
yew-struct-keyed 21_ready-memory 0.9634513854980468 0.9634513854980468 1
yew-struct-keyed 22_run-memory 1.4578094482421875 1.4999732971191406 0.97
yew-struct-keyed 23_update5-memory 1.4615478515625 1.5032615661621094 0.97
yew-struct-keyed 24_run5-memory 1.510845184326172 1.510845184326172 1
yew-struct-keyed 25_run-clear-memory 1.1296615600585938 1.1258888244628906 1.00
yew-struct-keyed 31_startup-ci 1791.88975 1886.865 0.95
yew-struct-keyed 32_startup-bt 51.10199999999999 39.49799999999999 1.29
yew-struct-keyed 34_startup-totalbytes 365.9482421875 365.94140625 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.