build: remove presubmit dependency on luvit-meta #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in yetone#2536 the project should either use luv bindings from luals or luvit-meta library, but not both, as they conflict with each other (especially with uv.uv_timer_t). Given that other projects such as kickstart.nvim and lazydev.nvim are switching to use the former, we should do the same and drop luvit-meta dependency. Also adjust code that was using luvit-meta's annotations for timers.
dtor
force-pushed
the
remove-luvit-meta-deps
branch
from
dfb129e to
b8444da
Compare
Instead of implementing synchronous call to a command line utility via vim.uv.spawn() switch to using vim.system(). Its return value (object) wait() method allows to specify timeout too. This makes code much simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2536 the project should either use luv bindings from luals or luvit-meta library, but not both, as they conflict with each other (especially with uv.uv_timer_t). Given that other projects such as kickstart.nvim and lazydev.nvim are switching to use the former, we should do the same and drop luvit-meta dependency.