Merge pull request #86 from yetanalytics/allow-empty-statements

[LRS-83] Allow empty statement batches
yetanalytics · Sep 24, 2024 · a1386be · a1386be
2 parents 5869bf7 + 63614c7
commit a1386be
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/xapi_schema/spec.cljc b/src/xapi_schema/spec.cljc
@@ -1327,7 +1327,7 @@
                    true)))))
 
 (s/def ::statements
-  (s/coll-of ::statement :into [] :min-count 1))
+  (s/coll-of ::statement :into []))
 
 (s/def ::lrs-statements
-  (s/coll-of ::lrs-statement :into [] :min-count 1))
+  (s/coll-of ::lrs-statement :into []))
diff --git a/test/xapi_schema/spec_test.cljc b/test/xapi_schema/spec_test.cljc
@@ -626,3 +626,14 @@
                       "verb" {"id" "http://adlnet.gov/expapi/verbs/voided"
                               "display" {"en-US" "voided"}}
                       "object" {"id" "http://example.com/activities/1"}})))
+
+(deftest statements-test
+  (testing "generic statememt batch"
+    (should-satisfy+ ::xs/statements
+                     [simple-statement]
+                     [simple-statement long-statement]
+                     []))
+  (testing "LRS retrieval statement batch"
+    (should-satisfy+ ::xs/lrs-statements
+                     [d/statement] ; This statement has ID and other required fields
+                     [])))