Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIO-based scaffolding #1602

Open
cdornan opened this issue May 28, 2019 · 9 comments
Open

RIO-based scaffolding #1602

cdornan opened this issue May 28, 2019 · 9 comments

Comments

@cdornan
Copy link

cdornan commented May 28, 2019

The scaffolding site I am using (yesod-simple) is based on ClassyPrelude — are there templates that are more RIO-orientated or plans to add them?

(I would be happy to help, but only after I have completed a project, and if nobody has done this already.)

@snoyberg
Copy link
Member

I started work on a branch of the yesod repo (appropriately called rio) which moves Yesod to rio in a significant way. In particular: replacing HandlerFor with RIO and moving over to rio's logging functionality. But I haven't had any time to really push it towards being usable, and it would be a major breaking release.

@cdornan
Copy link
Author

cdornan commented May 29, 2019

I can see how it could help but is translating the scaffolding to Rio contingent on getting the core rebuilt on Rio? It would be awesome to go the full Rio but having the scaffolding switched would be a significant help to folks unused to CP.

@cdornan
Copy link
Author

cdornan commented May 29, 2019

(Again, I would be happy to pick this up when ready. It’s surely not urgent and IMHO should not distract from critical core activities.)

@snoyberg
Copy link
Member

It depends on how deep the integration with rio is supposed to be I guess. The plans I had certainly required the overhaul, but maybe there's a smaller bite of the pie that'll work. If you're up for it, I'd definitely be interested in seeing if you can get something worthwhile out of just modifying the scaffolding. I'd be happy to advise.

@cdornan
Copy link
Author

cdornan commented May 29, 2019

Don't get me wrong — I would love to see the rio deep integration — I was just saying that we push them forward together.

I will gladly have a look at this issue when I am ready but if anybody else wants to pick this up in the meantime please do!

cdornan added a commit to cdornan/stack-templates that referenced this issue Jun 14, 2019
CF: yesodweb/yesod#1602
CC: @snoyberg

This template takes `yesod-simple` and replaces `classy-prelude-*`
with `rio`. I have checked that everything builds and runs out of the
box, and that the tests are green.

I have not (yet) used it in anger to develop an app, and I am but a
Yesod and RIO neophyte, so it needs careful reviewing.

Some points:

  * bounds on `aeson` and `yaml` were relaxed to allow those in the
    latest lts release (13.25);
  * `http-types`, `yesod-newsfeed` and `persistent` was added with
    no bounds restrictions — what restrictions should we use
    on these packages?
  * `rio >= 0.1.8.0` : is my starting point — can we relax the
    upper bound? What upper bound should we use?
  * To get `rio` to work with the current stack I am hiding parts of the
    `rio` logging system (I guess these will be addressed by
    [this work](yesodweb/yesod#1602 (comment))).
@cdornan
Copy link
Author

cdornan commented Jun 14, 2019

@snoyberg I have raised a PR to address this issue which at least superficially appears to get the job done but I think it should be carefully reviewed by somebody with a more than superficial understanding of both stacks. I am expecting it will need changes in preparation for a general release.

@cdornan
Copy link
Author

cdornan commented Jun 14, 2019

(It might be judged to be too confusing until the rio branch has been release, but it should at least be helpful for me in the meantime, even if it gets me a bit more familiar with Yesod.)

@cdornan
Copy link
Author

cdornan commented Jun 14, 2019

@snoyberg I don't know how urgently you would wanted to release 1.7 but I could clear a week to work on the rio branch over the summer.

@snoyberg
Copy link
Member

I have no urgency, so assistance and someone to bat ideas around with would be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants