-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIO-based scaffolding #1602
Comments
I started work on a branch of the |
I can see how it could help but is translating the scaffolding to Rio contingent on getting the core rebuilt on Rio? It would be awesome to go the full Rio but having the scaffolding switched would be a significant help to folks unused to CP. |
(Again, I would be happy to pick this up when ready. It’s surely not urgent and IMHO should not distract from critical core activities.) |
It depends on how deep the integration with rio is supposed to be I guess. The plans I had certainly required the overhaul, but maybe there's a smaller bite of the pie that'll work. If you're up for it, I'd definitely be interested in seeing if you can get something worthwhile out of just modifying the scaffolding. I'd be happy to advise. |
Don't get me wrong — I would love to see the rio deep integration — I was just saying that we push them forward together. I will gladly have a look at this issue when I am ready but if anybody else wants to pick this up in the meantime please do! |
CF: yesodweb/yesod#1602 CC: @snoyberg This template takes `yesod-simple` and replaces `classy-prelude-*` with `rio`. I have checked that everything builds and runs out of the box, and that the tests are green. I have not (yet) used it in anger to develop an app, and I am but a Yesod and RIO neophyte, so it needs careful reviewing. Some points: * bounds on `aeson` and `yaml` were relaxed to allow those in the latest lts release (13.25); * `http-types`, `yesod-newsfeed` and `persistent` was added with no bounds restrictions — what restrictions should we use on these packages? * `rio >= 0.1.8.0` : is my starting point — can we relax the upper bound? What upper bound should we use? * To get `rio` to work with the current stack I am hiding parts of the `rio` logging system (I guess these will be addressed by [this work](yesodweb/yesod#1602 (comment))).
@snoyberg I have raised a PR to address this issue which at least superficially appears to get the job done but I think it should be carefully reviewed by somebody with a more than superficial understanding of both stacks. I am expecting it will need changes in preparation for a general release. |
(It might be judged to be too confusing until the rio branch has been release, but it should at least be helpful for me in the meantime, even if it gets me a bit more familiar with Yesod.) |
@snoyberg I don't know how urgently you would wanted to release 1.7 but I could clear a week to work on the |
I have no urgency, so assistance and someone to bat ideas around with would be awesome! |
The scaffolding site I am using (yesod-simple) is based on ClassyPrelude — are there templates that are more RIO-orientated or plans to add them?
(I would be happy to help, but only after I have completed a project, and if nobody has done this already.)
The text was updated successfully, but these errors were encountered: