warp: Use more meaningful types instead of Bool
#998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
commented
Aug 1, 2024
| @@ -50,11 +51,13 @@ import Network.Wai.Handler.Warp.Settings ( | |||
|
|
|||
| ---------------------------------------------------------------- | |||
|
|
|||
| -- | first request on this connection? | |||
| data FirstRequest = FirstRequest | SubsequentRequest | |||
|
|
|||
| -- | Receiving a HTTP request from 'Connection' and parsing its header | |||
| -- to create 'Request'. | |||
| recvRequest | |||
There was a problem hiding this comment.
Apparently, this is re-exported from Network.Wai.Handler.Warp.Internal. @kazu-yamamoto @Vlix what are the stability guarantees for that module?
There was a problem hiding this comment.
We can change Internal at anytime without major version up.
|
I have fixed CI and rebase this PR onto https://github.com/kazu-yamamoto/wai/tree/ci |
|
I'll take a look at it tomorrow 👍 |
kazu-yamamoto
added a commit
to kazu-yamamoto/wai
that referenced
this pull request
Aug 6, 2024
|
With my refreshed head, it is easy to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overuse of booleans for all kinds of things makes it somewhat hard to follow the code that implements HTTP/1.1 keep-alive. This is a step towards trying to improve the situation.