Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instance Traversable UrlMap' #992

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

chris-martin
Copy link
Contributor

@chris-martin chris-martin commented May 17, 2024

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@Vlix
Copy link
Contributor

Vlix commented May 28, 2024

This looks fine, not a big change or anything.

If you could merge in master so that all the CI works again, we can probably merge this in 🤔

@kazu-yamamoto
Copy link
Contributor

@chris-martin Could you rebase and push -f this branch again?

@chris-martin
Copy link
Contributor Author

Rebased, checks are looking better.

@Vlix
Copy link
Contributor

Vlix commented Oct 27, 2024

CI fails on nightly because of bad constraints on http3. But they would succeed with the correct version of http-semantics.

Since version wai-extra-3.1.15 hasn't been released, please add this change to 3.1.15 in the Changelog (and don't forget to change all the @since declarations).

And to make all the tests pass, change the extra-deps section of stack-nightly.yaml to:

extra-deps:
  - http3-0.0.18
  - network-udp-0.0.0
  - quic-0.2.2
  - sockaddr-0.0.1

@kazu-yamamoto
Copy link
Contributor

@chris-martin master is green now. Would you rebase and push -f again?

Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 931eeb1 into yesodweb:master Nov 7, 2024
14 checks passed
@kazu-yamamoto
Copy link
Contributor

@chris-martin Merged. Thank you for your contribution!
@Vlix It's up to you to release a new version of wai-extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants