Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline syntax bug #969

Closed
wants to merge 1 commit into from

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Jan 4, 2024

warp-tls: when making multiline strings, the first \ on a new line doesn't escape the next character, it's the start of the next part of the string.

This will result in the following response (note the trailing rs)

HTTP/1.1 426 Upgrade Requiredr
Upgrade: TLS/1.0, HTTP/1.1r
Connection: Upgrader
Content-Type: text/plain

I'm not sure why this hasn't been a problem yet? Probably because it's the response when denying something, so if the response is off, it still indicates that it's a 426? 🤷

…doesn't escape the next character, it's the start of the next part of the string
@kazu-yamamoto kazu-yamamoto self-requested a review January 9, 2024 05:11
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

kazu-yamamoto added a commit to kazu-yamamoto/wai that referenced this pull request Jan 9, 2024
@kazu-yamamoto
Copy link
Contributor

Rebased and merged!

@Vlix Vlix deleted the multiline-string-syntax-mistake branch January 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants