Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label internal Windows hack thread #1021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasagredo
Copy link

This thread is inaccessible from outside.

Before submitting your PR, check that you've:

  • Bumped the version number

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@jasagredo
Copy link
Author

Should I bump the version number or add a changelog entry for this?

@Vlix
Copy link
Contributor

Vlix commented Jan 27, 2025

This thread is inaccessible from outside.

What do you mean with this?
This PR is only for labeling the hacky thread?

@jasagredo
Copy link
Author

I mean it is not possible for a user to label this thread. And yes, the PR is only for labeling the thread.

Copy link
Contributor

@Vlix Vlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the labeling outside the fork is less code and saves a few cycles, maybe 🙃

I've zero objections to this PR though, in general.

warp/Network/Wai/Handler/Warp/Windows.hs Outdated Show resolved Hide resolved
@Vlix
Copy link
Contributor

Vlix commented Jan 28, 2025

Nightly Windows job fails with:
doctest > C:/Users/runneradmin/AppData/Local/Programs/stack/x86_64-windows/ghc-9.10.1/mingw/bin/strip.exe: error: Permission denied

I've heard about this before, doesn't block this PR.

@jasagredo How quickly do you need a release for this?
Please either bump the lower version and add an entry in the ChangeLog for that new version, or just add to the Changelog with an "Unreleased:" title.

@jasagredo
Copy link
Author

Will add an Unreleased point in the changelog, thanks.

From my side there is no rush on getting this released. Whenever a new version is released is fine.

@kazu-yamamoto
Copy link
Contributor

Nice catch!
Labeling threads is very good to me.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants