-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label internal Windows hack thread #1021
base: master
Are you sure you want to change the base?
Conversation
Should I bump the version number or add a changelog entry for this? |
What do you mean with this? |
I mean it is not possible for a user to label this thread. And yes, the PR is only for labeling the thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the labeling outside the fork is less code and saves a few cycles, maybe 🙃
I've zero objections to this PR though, in general.
Co-authored-by: Felix Paulusma <[email protected]>
Nightly Windows job fails with: I've heard about this before, doesn't block this PR. @jasagredo How quickly do you need a release for this? |
Will add an Unreleased point in the changelog, thanks. From my side there is no rush on getting this released. Whenever a new version is released is fine. |
Nice catch! |
This thread is inaccessible from outside.
Before submitting your PR, check that you've:
After submitting your PR: